From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82456-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4914 invoked by alias); 20 Jul 2011 16:59:07 -0000
Received: (qmail 4905 invoked by uid 22791); 20 Jul 2011 16:59:06 -0000
X-SWARE-Spam-Status: No, hits=-1.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 16:58:41 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LON00A005RWEN00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 20 Jul 2011 19:58:28 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.133.66]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LON009ED5TFU570@a-mtaout22.012.net.il>; Wed, 20 Jul 2011 19:58:28 +0300 (IDT)
Date: Wed, 20 Jul 2011 17:10:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] [python] Prompt substitution
In-reply-to: <m3oc0r1tjk.fsf@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83pql4vqh5.fsf@gnu.org>
References: <m3oc0r1tjk.fsf@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00551.txt.bz2

> From: Phil Muldoon <pmuldoon@redhat.com>
> Date: Mon, 18 Jul 2011 16:45:51 +0100
> 
> 2011-07-18  Phil Muldoon  <pmuldoon@redhat.com>
> 
> 	* observer.texi (GDB Observers): Add before_prompt observer.
> 	* gdb.texinfo (Basic Python): Add documentation for setting,
> 	getting and prompt substitution.

Thanks.

> +@defun set_current_prompt @r{[}new_prompt@r{]}
> +Sets the @value{GDBN} prompt to @var{new_prompt}.
   ^^^^
"Set", not "sets", to be consistent with the way we describe other
methods.

You don't say what is the effect of omitting new_prompt (which is
optional, according to the "[...]" syntax).

> +@defop Operation {@value{GDBN}} prompt_hook [current_prompt]
                                               ^^^^^^^^^^^^^^^^
You need @r{} here as well.

Also, what happens if current_prompt is omitted?

> +Called before a top-level prompt is displayed. @var{current_prompt} is
                                                ^^
Two spaces, please.

The documentation parts are okay with these comments.