From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83372-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11771 invoked by alias); 30 Aug 2011 20:18:38 -0000
Received: (qmail 11763 invoked by uid 22791); 30 Aug 2011 20:18:37 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 20:18:22 +0000
Received: (qmail 12488 invoked from network); 30 Aug 2011 20:18:22 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 30 Aug 2011 20:18:22 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, pmuldoon@redhat.com
Subject: Re: [patch] [python] Prompt substitution
Date: Tue, 30 Aug 2011 20:18:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.0; x86_64; ; )
Cc: Tom Tromey <tromey@redhat.com>
References: <m3oc0r1tjk.fsf@redhat.com> <m3ipqy2dp6.fsf@fleche.redhat.com> <m362mxxk3f.fsf@redhat.com>
In-Reply-To: <m362mxxk3f.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201108302118.18505.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00632.txt.bz2

On Wednesday 20 July 2011 12:33:24, Phil Muldoon wrote:
> +gdb_test_multiple "set prompt blah " "set blah in GDB" {
> +    -re "\[\r\n\]$newprompt2 $" {
> +       pass "set prompt blah overriden"
> +    }
> +}
> +
> +gdb_test_multiple "python gdb.prompt_hook = None" "Delete hook" {
> +    -re "\[\r\n\]$newprompt2 $" {
> +       pass "Delete old hook"
> +    }
> +}

Hmm:

...
PASS: gdb.python/python.exp: show prompt shows guarded prompt
set prompt blah 
py prompt 2 PASS: gdb.python/python.exp: set prompt blah overriden
python gdb.prompt_hook = None
py prompt 2 PASS: gdb.python/python.exp: Delete old hook

I think this last PASS is actually a bug.  We've disabled the python
hook, so we should get the "set prompt" prompt back ("blah")
instead of still seeing the python prompt.  Agree?

(My WIP no-prompt-stack patch turned that into a FAIL,
but it looks like it's a bug fix, not a regression.)

-- 
Pedro Alves