[PATCH] Fix deftypefn in fopen_unlocked.c

[PATCH] Fix deftypefn in fopen_unlocked.c

[Eli Zaretskii]

More of the same:

2005-05-14  Eli Zaretskii  <eliz@gnu.org>

	* fopen_unlocked.c: Enclose multi-word data types in @deftypefn in
	braces.


Index: libiberty/fopen_unlocked.c
===================================================================
RCS file: /cvs/src/src/libiberty/fopen_unlocked.c,v
retrieving revision 1.4
diff -u -r1.4 fopen_unlocked.c
--- libiberty/fopen_unlocked.c	10 May 2005 15:33:33 -0000	1.4
+++ libiberty/fopen_unlocked.c	14 May 2005 08:53:13 -0000
@@ -36,7 +36,7 @@
 
 @end deftypefn
 
-@deftypefn Extension FILE * fopen_unlocked (const char *@var{path}, const char * @var{mode})
+@deftypefn Extension {FILE *} fopen_unlocked (const char *@var{path}, const char * @var{mode})
 
 Opens and returns a @code{FILE} pointer via @code{fopen}.  If the
 operating system supports it, ensure that the stream is setup to avoid
@@ -45,7 +45,7 @@
 
 @end deftypefn
 
-@deftypefn Extension FILE * fdopen_unlocked (int @var{fildes}, const char * @var{mode})
+@deftypefn Extension {FILE *} fdopen_unlocked (int @var{fildes}, const char * @var{mode})
 
 Opens and returns a @code{FILE} pointer via @code{fdopen}.  If the
 operating system supports it, ensure that the stream is setup to avoid
@@ -54,7 +54,7 @@
 
 @end deftypefn
 
-@deftypefn Extension FILE * freopen_unlocked (const char * @var{path}, const char * @var{mode}, FILE * @var{stream})
+@deftypefn Extension {FILE *} freopen_unlocked (const char * @var{path}, const char * @var{mode}, FILE * @var{stream})
 
 Opens and returns a @code{FILE} pointer via @code{freopen}.  If the
 operating system supports it, ensure that the stream is setup to avoid

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Ian Lance Taylor]

"Eli Zaretskii" <eliz@gnu.org> writes:

> More of the same:
> 
> 2005-05-14  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* fopen_unlocked.c: Enclose multi-word data types in @deftypefn in
> 	braces.

This is OK.  Thanks.

Ian

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Ian Lance Taylor <ian@airs.com> writes:

> "Eli Zaretskii" <eliz@gnu.org> writes:
>
>> More of the same:
>> 
>> 2005-05-14  Eli Zaretskii  <eliz@gnu.org>
>> 
>> 	* fopen_unlocked.c: Enclose multi-word data types in @deftypefn in
>> 	braces.
>
> This is OK.  Thanks.

Committed to GCC mainline,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Joseph S. Myers]

On Sun, 15 May 2005, Andreas Jaeger wrote:

> Ian Lance Taylor <ian@airs.com> writes:
> 
> > "Eli Zaretskii" <eliz@gnu.org> writes:
> >
> >> More of the same:
> >> 
> >> 2005-05-14  Eli Zaretskii  <eliz@gnu.org>
> >> 
> >> 	* fopen_unlocked.c: Enclose multi-word data types in @deftypefn in
> >> 	braces.
> >
> > This is OK.  Thanks.
> 
> Committed to GCC mainline,

functions.texi should be regenerated when committing this patches (and it 
should be verified that the new functions.texi does indeed pass "make 
info" and "make dvi" before committing it).

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

"Joseph S. Myers" <joseph@codesourcery.com> writes:

> On Sun, 15 May 2005, Andreas Jaeger wrote:
>
>> Ian Lance Taylor <ian@airs.com> writes:
>> 
>> > "Eli Zaretskii" <eliz@gnu.org> writes:
>> >
>> >> More of the same:
>> >> 
>> >> 2005-05-14  Eli Zaretskii  <eliz@gnu.org>
>> >> 
>> >> 	* fopen_unlocked.c: Enclose multi-word data types in @deftypefn in
>> >> 	braces.
>> >
>> > This is OK.  Thanks.
>> 
>> Committed to GCC mainline,
>
> functions.texi should be regenerated when committing this patches (and it 
> should be verified that the new functions.texi does indeed pass "make 
> info" and "make dvi" before committing it).

Ok, will take care of it,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Eli Zaretskii]

> Date: Sun, 15 May 2005 17:25:15 +0000 (UTC)
> From: "Joseph S. Myers" <joseph@codesourcery.com>
> cc: Ian Lance Taylor <ian@airs.com>, Eli Zaretskii <eliz@gnu.org>, 
>     gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
> 
> functions.texi should be regenerated when committing this patches

Right.  I didn't do that, since I cannot commit changes to the GCC
repository.

> (and it should be verified that the new functions.texi does indeed
> pass "make info" and "make dvi" before committing it).

I verified the former before I submitted the patches.  As for the
latter, unless someone is going to preview the DVI output and make
sure it looks okay in print, "make info" can be regarded as a
good-enough test for "make dvi" as well.

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Joseph S. Myers]

On Sun, 15 May 2005, Eli Zaretskii wrote:

> > (and it should be verified that the new functions.texi does indeed
> > pass "make info" and "make dvi" before committing it).
> 
> I verified the former before I submitted the patches.  As for the
> latter, unless someone is going to preview the DVI output and make
> sure it looks okay in print, "make info" can be regarded as a
> good-enough test for "make dvi" as well.

On the contrary, many times patches have broken "make dvi" but passed 
"make info".  See the last such breakage in libiberty 
<http://gcc.gnu.org/ml/gcc-patches/2005-03/msg02853.html> for an example.  
"make info" and "make dvi" detect different subsets of invalid Texinfo; 
http://gcc.gnu.org/contribute.html specifies both for documentation 
patches for a reason.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

"Joseph S. Myers" <joseph@codesourcery.com> writes:

> functions.texi should be regenerated when committing this patches (and it 
> should be verified that the new functions.texi does indeed pass "make 
> info" and "make dvi" before committing it).

FYI: Everything has been done - and was successfull.  I committed
functions.texi already...

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Eli Zaretskii]

> Date: Sun, 15 May 2005 19:52:01 +0000 (UTC)
> From: "Joseph S. Myers" <joseph@codesourcery.com>
> cc: aj@suse.de, ian@airs.com, gcc-patches@gcc.gnu.org, 
>     gdb-patches@sourceware.org
> 
> > I verified the former before I submitted the patches.  As for the
> > latter, unless someone is going to preview the DVI output and make
> > sure it looks okay in print, "make info" can be regarded as a
> > good-enough test for "make dvi" as well.
> 
> On the contrary, many times patches have broken "make dvi" but passed 
> "make info".

I didn't say it was a perfect test, just a good-enough one.

> See the last such breakage in libiberty 
> <http://gcc.gnu.org/ml/gcc-patches/2005-03/msg02853.html> for an example.  

I didn't change any places that could cause similar problems in this
specific manual.

> "make info" and "make dvi" detect different subsets of invalid Texinfo; 

In general, yes; but in the case of libiberty, not really.

P.S.  If you have such stringent standards for accepting docs patches,
how come what I found needed so many fixes?  I found those problems by
simply looking at the index; any reasonable QA should have discovered
that long ago.

Re: [PATCH] Fix deftypefn in fopen_unlocked.c

[Eli Zaretskii]

> From: Andreas Jaeger <aj@suse.de>
> Cc: Ian Lance Taylor <ian@airs.com>, Eli Zaretskii <eliz@gnu.org>,
> 	gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
> Date: Sun, 15 May 2005 22:20:51 +0200
> 
> FYI: Everything has been done - and was successfull.  I committed
> functions.texi already...

Thanks again.