Re: [PATCH] Fix deftypefn in fopen_unlocked.c

["Joseph S. Myers" <joseph@codesourcery.com>]

On Sun, 15 May 2005, Eli Zaretskii wrote:

> > (and it should be verified that the new functions.texi does indeed
> > pass "make info" and "make dvi" before committing it).
> 
> I verified the former before I submitted the patches.  As for the
> latter, unless someone is going to preview the DVI output and make
> sure it looks okay in print, "make info" can be regarded as a
> good-enough test for "make dvi" as well.

On the contrary, many times patches have broken "make dvi" but passed 
"make info".  See the last such breakage in libiberty 
<http://gcc.gnu.org/ml/gcc-patches/2005-03/msg02853.html> for an example.  
"make info" and "make dvi" detect different subsets of invalid Texinfo; 
http://gcc.gnu.org/contribute.html specifies both for documentation 
patches for a reason.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)