From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32168 invoked by alias); 15 May 2005 19:52:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31857 invoked from network); 15 May 2005 19:52:07 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sourceware.org with SMTP; 15 May 2005 19:52:07 -0000 Received: (qmail 13307 invoked from network); 15 May 2005 19:52:03 -0000 Received: from localhost (HELO digraph.polyomino.org.uk) (joseph@127.0.0.1) by mail.codesourcery.com with DES-CBC3-SHA encrypted SMTP; 15 May 2005 19:52:03 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.44) id 1DXP9d-0001gf-IO; Sun, 15 May 2005 19:52:01 +0000 Date: Sun, 15 May 2005 20:16:00 -0000 From: "Joseph S. Myers" X-X-Sender: jsm28@digraph.polyomino.org.uk To: Eli Zaretskii cc: aj@suse.de, ian@airs.com, gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Fix deftypefn in fopen_unlocked.c In-Reply-To: <01c55985$Blat.v2.4$50507620@zahav.net.il> Message-ID: References: <01c55862$Blat.v2.4$44a795c0@zahav.net.il> <01c55985$Blat.v2.4$50507620@zahav.net.il> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-05/txt/msg00387.txt.bz2 On Sun, 15 May 2005, Eli Zaretskii wrote: > > (and it should be verified that the new functions.texi does indeed > > pass "make info" and "make dvi" before committing it). > > I verified the former before I submitted the patches. As for the > latter, unless someone is going to preview the DVI output and make > sure it looks okay in print, "make info" can be regarded as a > good-enough test for "make dvi" as well. On the contrary, many times patches have broken "make dvi" but passed "make info". See the last such breakage in libiberty for an example. "make info" and "make dvi" detect different subsets of invalid Texinfo; http://gcc.gnu.org/contribute.html specifies both for documentation patches for a reason. -- Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/ jsm@polyomino.org.uk (personal mail) joseph@codesourcery.com (CodeSourcery mail) jsm28@gcc.gnu.org (Bugzilla assignments and CCs)