[RFA] Set the default of disassemble-next-line to off

[RFA] Set the default of disassemble-next-line to off

[Hui Zhu]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi guys,

I make the patches to set the default of disassemble-next-line to off.
 Please help me review it.

2009-04-19  Hui Zhu  <teawater@gmail.com>

	* stack.c (_initialize_stack): Set the default of
	disassemble-next-line to off.

2009-04-19  Hui Zhu  <teawater@gmail.com>

	* gdbint.texinfo (disassemble-next-line): Set the default of
	disassemble-next-line to off.

Thanks,
Hui

[-- Attachment #2: change-disassemble-next-line-off.txt --]
[-- Type: text/plain, Size: 856 bytes --]

---
 stack.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/stack.c
+++ b/stack.c
@@ -2149,13 +2149,13 @@ Set whether to disassemble next source l
 Show whether to disassemble next source line when execution stops."), _("\
 If ON, GDB will display disassembly of the next source line when\n\
 execution of the program being debugged stops.\n\
-If AUTO (which is the default), or there's no line info to determine\n\
+If AUTO, or there's no line info to determine\n\
 the source line of the next instruction, display disassembly of next\n\
 instruction instead."),
 			        NULL,
 			        show_disassemble_next_line,
 			        &setlist, &showlist);
-  disassemble_next_line = AUTO_BOOLEAN_AUTO;
+  disassemble_next_line = AUTO_BOOLEAN_FALSE;
 
 #if 0
   add_cmd ("backtrace-limit", class_stack, set_backtrace_limit_command, _(\

[-- Attachment #3: change-disassemble-next-line-off-doc.txt --]
[-- Type: text/plain, Size: 715 bytes --]

---
 doc/gdb.texinfo |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- a/doc/gdb.texinfo
+++ b/doc/gdb.texinfo
@@ -6061,9 +6061,8 @@ Show the current setting of the disassem
 Control whether or not @value{GDBN} will disassemble next source line
 when execution stops.  If ON, GDB will display disassembly of the next
 source line when execution of the program being debugged stops.
-If AUTO (which is the default), or there's no line info to determine
-the source line of the next instruction, display disassembly of next
-instruction instead.
+If AUTO, or there's no line info to determine the source line of the
+next instruction, display disassembly of next instruction instead.
 @end table
 
 

Re: [RFA] Set the default of disassemble-next-line to off

[Eli Zaretskii]

> Date: Sun, 19 Apr 2009 21:47:25 +0800
> From: Hui Zhu <teawater@gmail.com>
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> 
> 2009-04-19  Hui Zhu  <teawater@gmail.com>
> 
> 	* gdbint.texinfo (disassemble-next-line): Set the default of
> 	disassemble-next-line to off.

This is fine with me.  Thanks.

Re: [RFA] Set the default of disassemble-next-line to off

[Hui Zhu]

Thanks Eli.

Hui

On Mon, Apr 20, 2009 at 01:42, Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Date: Sun, 19 Apr 2009 21:47:25 +0800
> > From: Hui Zhu <teawater@gmail.com>
> > Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> >
> > 2009-04-19  Hui Zhu  <teawater@gmail.com>
> >
> >       * gdbint.texinfo (disassemble-next-line): Set the default of
> >       disassemble-next-line to off.
>
> This is fine with me.  Thanks.

Re: [RFA] Set the default of disassemble-next-line to off

[Tom Tromey]

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> -If AUTO (which is the default), or there's no line info to determine\n\
Hui> +If AUTO, or there's no line info to determine\n\
Hui>  the source line of the next instruction, display disassembly of next\n\
Hui>  instruction instead."),

It seems to me that this should read:

    If AUTO, and there's no line info to determine [...]

The actual code change is fine :-)

thanks,
Tom

Re: [RFA] Set the default of disassemble-next-line to off

[Hui Zhu]

On Tue, Apr 21, 2009 at 02:16, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> -If AUTO (which is the default), or there's no line info to determine\n\
> Hui> +If AUTO, or there's no line info to determine\n\
> Hui>  the source line of the next instruction, display disassembly of next\n\
> Hui>  instruction instead."),
>
> It seems to me that this should read:
>
>    If AUTO, and there's no line info to determine [...]

If auto:
if this is no line info, it will output the next instruction.
if this is line inof, it will output nothing.

If on:
if this is no line info, it will output the next instruction.
if this is line inof, it will display disassembly of the next source
line whenexecution of the program being debugged stops.

If off,
it will output nothing.


I have no idea to write it clear.
Could you please help me with it?


>
> The actual code change is fine :-)

Thanks, it is checked in.


Hui

Re: [RFA] Set the default of disassemble-next-line to off

[Eli Zaretskii]

> Date: Wed, 22 Apr 2009 14:42:36 +0800
> From: Hui Zhu <teawater@gmail.com>
> Cc: Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>, 
> 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> 
> On Tue, Apr 21, 2009 at 02:16, Tom Tromey <tromey@redhat.com> wrote:
> >>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
> >
> > Hui> -If AUTO (which is the default), or there's no line info to determine\n\
> > Hui> +If AUTO, or there's no line info to determine\n\
> > Hui>  the source line of the next instruction, display disassembly of next\n\
> > Hui>  instruction instead."),
> >
> > It seems to me that this should read:
> >
> >    If AUTO, and there's no line info to determine [...]
> 
> If auto:
> if this is no line info, it will output the next instruction.
> if this is line inof, it will output nothing.
> 
> If on:
> if this is no line info, it will output the next instruction.
> if this is line inof, it will display disassembly of the next source
> line whenexecution of the program being debugged stops.
> 
> If off,
> it will output nothing.
> 
> 
> I have no idea to write it clear.
> Could you please help me with it?

I already suggested a change in the doc string, see

  http://sourceware.org/ml/gdb-patches/2009-04/msg00416.html

I didn't see any responses.  If the text I suggest there is clear, I
will fix the manual as well.

Re: [RFA] Set the default of disassemble-next-line to off

[Tom Tromey]

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> I already suggested a change in the doc string, see
Eli>   http://sourceware.org/ml/gdb-patches/2009-04/msg00416.html
Eli> I didn't see any responses.  If the text I suggest there is clear, I
Eli> will fix the manual as well.

That looks good to me.
It will need a small update for the change of the default.

Tom

Re: [RFA] Set the default of disassemble-next-line to off

[Eli Zaretskii]

> Cc: Hui Zhu <teawater@gmail.com>, brobecker@adacore.com,
>         gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Wed, 22 Apr 2009 12:45:18 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> I already suggested a change in the doc string, see
> Eli>   http://sourceware.org/ml/gdb-patches/2009-04/msg00416.html
> Eli> I didn't see any responses.  If the text I suggest there is clear, I
> Eli> will fix the manual as well.
> 
> That looks good to me.
> It will need a small update for the change of the default.

Thanks.  I committed it, with that change.

Re: [RFA] Set the default of disassemble-next-line to off

[Hui Zhu]

On Thu, Apr 23, 2009 at 01:11, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Wed, 22 Apr 2009 14:42:36 +0800
>> From: Hui Zhu <teawater@gmail.com>
>> Cc: Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>,
>>       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
>>
>> On Tue, Apr 21, 2009 at 02:16, Tom Tromey <tromey@redhat.com> wrote:
>> >>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>> >
>> > Hui> -If AUTO (which is the default), or there's no line info to determine\n\
>> > Hui> +If AUTO, or there's no line info to determine\n\
>> > Hui>  the source line of the next instruction, display disassembly of next\n\
>> > Hui>  instruction instead."),
>> >
>> > It seems to me that this should read:
>> >
>> >    If AUTO, and there's no line info to determine [...]
>>
>> If auto:
>> if this is no line info, it will output the next instruction.
>> if this is line inof, it will output nothing.
>>
>> If on:
>> if this is no line info, it will output the next instruction.
>> if this is line inof, it will display disassembly of the next source
>> line whenexecution of the program being debugged stops.
>>
>> If off,
>> it will output nothing.
>>
>>
>> I have no idea to write it clear.
>> Could you please help me with it?
>
> I already suggested a change in the doc string, see
>
>  http://sourceware.org/ml/gdb-patches/2009-04/msg00416.html
>
> I didn't see any responses.  If the text I suggest there is clear, I
> will fix the manual as well.
>


Everything of this patch is very clear.

+If AUTO (which is the default), display disassembly of next\n\
(which is the default) need move to
++If OFF (which is the default) ,

After updated it, it's OK for me.

btw, I think gdb.texinfo need this patch too.

Thanks,
Hui

Re: [RFA] Set the default of disassemble-next-line to off

[Eli Zaretskii]

> Date: Thu, 23 Apr 2009 11:45:59 +0800
> From: Hui Zhu <teawater@gmail.com>
> Cc: tromey@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org
> 
> Everything of this patch is very clear.
> 
> +If AUTO (which is the default), display disassembly of next\n\
> (which is the default) need move to
> ++If OFF (which is the default) ,
> 
> After updated it, it's OK for me.
> 
> btw, I think gdb.texinfo need this patch too.

I installed the following patch:

2009-04-25  Eli Zaretskii  <eliz@gnu.org>

	* gdb.texinfo (Machine Code) <disassemble-next-line>: Improve and
	clarify the wording.

Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.585
diff -u -r1.585 gdb.texinfo
--- gdb/doc/gdb.texinfo	23 Apr 2009 21:28:20 -0000	1.585
+++ gdb/doc/gdb.texinfo	25 Apr 2009 09:53:08 -0000
@@ -6071,11 +6071,21 @@
 @kindex show disassemble-next-line
 @item set disassemble-next-line
 @itemx show disassemble-next-line
-Control whether or not @value{GDBN} will disassemble next source line
-when execution stops.  If ON, GDB will display disassembly of the next
-source line when execution of the program being debugged stops.
-If AUTO, or there's no line info to determine the source line of the
-next instruction, display disassembly of next instruction instead.
+Control whether or not @value{GDBN} will disassemble the next source
+line or instruction when execution stops.  If ON, @value{GDBN} will
+display disassembly of the next source line when execution of the
+program being debugged stops.  This is @emph{in addition} to
+displaying the source line itself, which @value{GDBN} always does if
+possible.  If the next source line cannot be displayed for some reason
+(e.g., if @value{GDBN} cannot find the source file, or there's no line
+info in the debug info), @value{GDBN} will display disassembly of the
+next @emph{instruction} instead of showing the next source line.  If
+AUTO, @value{GDBN} will display disassembly of next instruction only
+if the source line cannot be displayed.  This setting causes
+@value{GDBN} to display some feedback when you step through a function
+with no line info or whose source file is unavailable.  The default is
+OFF, which means never display the disassembly of the next line or
+instruction.
 @end table