From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20016 invoked by alias); 23 Apr 2009 03:46:08 -0000 Received: (qmail 20007 invoked by uid 22791); 23 Apr 2009 03:46:07 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.190) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Apr 2009 03:46:02 +0000 Received: by ti-out-0910.google.com with SMTP id a1so39638tib.12 for ; Wed, 22 Apr 2009 20:45:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.43.20 with SMTP id q20mr44570tiq.15.1240458359159; Wed, 22 Apr 2009 20:45:59 -0700 (PDT) In-Reply-To: <83eivkhavi.fsf@gnu.org> References: <83eivkhavi.fsf@gnu.org> Date: Thu, 23 Apr 2009 03:46:00 -0000 Message-ID: Subject: Re: [RFA] Set the default of disassemble-next-line to off From: Hui Zhu To: Eli Zaretskii Cc: tromey@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00634.txt.bz2 On Thu, Apr 23, 2009 at 01:11, Eli Zaretskii wrote: >> Date: Wed, 22 Apr 2009 14:42:36 +0800 >> From: Hui Zhu >> Cc: Joel Brobecker , Eli Zaretskii , >> =A0 =A0 =A0 "gdb-patches@sourceware.org" >> >> On Tue, Apr 21, 2009 at 02:16, Tom Tromey wrote: >> >>>>>> "Hui" =3D=3D Hui Zhu writes: >> > >> > Hui> -If AUTO (which is the default), or there's no line info to deter= mine\n\ >> > Hui> +If AUTO, or there's no line info to determine\n\ >> > Hui> =A0the source line of the next instruction, display disassembly o= f next\n\ >> > Hui> =A0instruction instead."), >> > >> > It seems to me that this should read: >> > >> > =A0 =A0If AUTO, and there's no line info to determine [...] >> >> If auto: >> if this is no line info, it will output the next instruction. >> if this is line inof, it will output nothing. >> >> If on: >> if this is no line info, it will output the next instruction. >> if this is line inof, it will display disassembly of the next source >> line whenexecution of the program being debugged stops. >> >> If off, >> it will output nothing. >> >> >> I have no idea to write it clear. >> Could you please help me with it? > > I already suggested a change in the doc string, see > > =A0http://sourceware.org/ml/gdb-patches/2009-04/msg00416.html > > I didn't see any responses. =A0If the text I suggest there is clear, I > will fix the manual as well. > Everything of this patch is very clear. +If AUTO (which is the default), display disassembly of next\n\ (which is the default) need move to ++If OFF (which is the default) , After updated it, it's OK for me. btw, I think gdb.texinfo need this patch too. Thanks, Hui