[3/4] RFC: add missing quote to test

[3/4] RFC: add missing quote to test

[Tom Tromey]

A -gdwarf-4 regression:

-PASS: gdb.cp/static-method.exp: list 'static-method.cc':xxx::(anonymous namespace)::A::func'
+FAIL: gdb.cp/static-method.exp: list 'static-method.cc':xxx::(anonymous namespace)::A::func'

Note the unpaired single quote in the test name.

I don't know why this works without -gdwarf-4.  I think it is a test
suite bug -- and in any case not something we want to bless by having it
in the test suite.

Keith, any comments on this?

Built and regtested by the buildbot.

Tom

b/gdb/testsuite/ChangeLog:
2011-07-15  Tom Tromey  <tromey@redhat.com>

	* gdb.cp/static-method.exp: Add missing single quote.

From bc6d1554384655e04f3c5f209237846001cc76b3 Mon Sep 17 00:00:00 2001
From: Tom Tromey <tromey@redhat.com>
Date: Fri, 15 Jul 2011 10:17:41 -0600
Subject: [PATCH 3/4] add missing quote to test case

---
 gdb/testsuite/ChangeLog                |    4 ++++
 gdb/testsuite/gdb.cp/static-method.exp |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/gdb/testsuite/gdb.cp/static-method.exp b/gdb/testsuite/gdb.cp/static-method.exp
index 9867c2c..e4a767e 100644
--- a/gdb/testsuite/gdb.cp/static-method.exp
+++ b/gdb/testsuite/gdb.cp/static-method.exp
@@ -70,7 +70,7 @@ foreach test $methods {
     # with the filename pre-pended.
     gdb_test "list ${srcfile}:$test" $result
     gdb_test "list '${srcfile}:$test'" $result
-    gdb_test "list '${srcfile}':$test'" $result
+    gdb_test "list '${srcfile}':'$test'" $result
     gdb_test "list ${srcfile}:'$test'" $result
 
     # Test setting and hitting a breakoint at the function/method.
-- 
1.7.6

Re: [3/4] RFC: add missing quote to test

[Keith Seitz]

On 07/15/2011 11:08 AM, Tom Tromey wrote:

> Note the unpaired single quote in the test name.

Yeah, that's clearly a mistake.

> I don't know why this works without -gdwarf-4.  I think it is a test
> suite bug -- and in any case not something we want to bless by having it
> in the test suite.

Using the same tree? That is unexpected. Otherwise, I could pretty 
easily attribute this to linespec.c churn.

Keith

Re: [3/4] RFC: add missing quote to test

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> On 07/15/2011 11:08 AM, Tom Tromey wrote:
Tom> Note the unpaired single quote in the test name.

Keith> Yeah, that's clearly a mistake.

Thanks.  I'm checking this in now.

Tom> I don't know why this works without -gdwarf-4.  I think it is a test
Tom> suite bug -- and in any case not something we want to bless by having it
Tom> in the test suite.

Keith> Using the same tree? That is unexpected. Otherwise, I could pretty
Keith> easily attribute this to linespec.c churn.

Yes, same tree:

make check RUNTESTFLAGS='--target_board unix/gdb:debug_flags=-gdwarf-4  static-method.exp'
[...]
FAIL: gdb.cp/static-method.exp: list 'static-method.cc':xxx::(anonymous namespace)::A::func'
# of expected passes		11
# of unexpected failures	1


make check RUNTESTFLAGS='static-method.exp'
# of expected passes		12

Tom