Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Keith Seitz <keiths@redhat.com>
Subject: [3/4] RFC: add missing quote to test
Date: Fri, 15 Jul 2011 18:15:00 -0000	[thread overview]
Message-ID: <m3mxgfbenm.fsf@fleche.redhat.com> (raw)

A -gdwarf-4 regression:

-PASS: gdb.cp/static-method.exp: list 'static-method.cc':xxx::(anonymous namespace)::A::func'
+FAIL: gdb.cp/static-method.exp: list 'static-method.cc':xxx::(anonymous namespace)::A::func'

Note the unpaired single quote in the test name.

I don't know why this works without -gdwarf-4.  I think it is a test
suite bug -- and in any case not something we want to bless by having it
in the test suite.

Keith, any comments on this?

Built and regtested by the buildbot.

Tom

b/gdb/testsuite/ChangeLog:
2011-07-15  Tom Tromey  <tromey@redhat.com>

	* gdb.cp/static-method.exp: Add missing single quote.

From bc6d1554384655e04f3c5f209237846001cc76b3 Mon Sep 17 00:00:00 2001
From: Tom Tromey <tromey@redhat.com>
Date: Fri, 15 Jul 2011 10:17:41 -0600
Subject: [PATCH 3/4] add missing quote to test case

---
 gdb/testsuite/ChangeLog                |    4 ++++
 gdb/testsuite/gdb.cp/static-method.exp |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/gdb/testsuite/gdb.cp/static-method.exp b/gdb/testsuite/gdb.cp/static-method.exp
index 9867c2c..e4a767e 100644
--- a/gdb/testsuite/gdb.cp/static-method.exp
+++ b/gdb/testsuite/gdb.cp/static-method.exp
@@ -70,7 +70,7 @@ foreach test $methods {
     # with the filename pre-pended.
     gdb_test "list ${srcfile}:$test" $result
     gdb_test "list '${srcfile}:$test'" $result
-    gdb_test "list '${srcfile}':$test'" $result
+    gdb_test "list '${srcfile}':'$test'" $result
     gdb_test "list ${srcfile}:'$test'" $result
 
     # Test setting and hitting a breakoint at the function/method.
-- 
1.7.6


             reply	other threads:[~2011-07-15 18:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15 18:15 Tom Tromey [this message]
2011-07-15 18:47 ` Keith Seitz
2011-07-18 15:33   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3mxgfbenm.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox