From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25837 invoked by alias); 15 Jul 2011 18:08:30 -0000 Received: (qmail 25828 invoked by uid 22791); 15 Jul 2011 18:08:29 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_GD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Jul 2011 18:08:15 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6FI8FOn005338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 15 Jul 2011 14:08:15 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6FI8Ehg004486; Fri, 15 Jul 2011 14:08:14 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6FI8DKe013919; Fri, 15 Jul 2011 14:08:13 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [3/4] RFC: add missing quote to test CC: Keith Seitz Date: Fri, 15 Jul 2011 18:15:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00394.txt.bz2 A -gdwarf-4 regression: -PASS: gdb.cp/static-method.exp: list 'static-method.cc':xxx::(anonymous namespace)::A::func' +FAIL: gdb.cp/static-method.exp: list 'static-method.cc':xxx::(anonymous namespace)::A::func' Note the unpaired single quote in the test name. I don't know why this works without -gdwarf-4. I think it is a test suite bug -- and in any case not something we want to bless by having it in the test suite. Keith, any comments on this? Built and regtested by the buildbot. Tom b/gdb/testsuite/ChangeLog: 2011-07-15 Tom Tromey * gdb.cp/static-method.exp: Add missing single quote. >From bc6d1554384655e04f3c5f209237846001cc76b3 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 15 Jul 2011 10:17:41 -0600 Subject: [PATCH 3/4] add missing quote to test case --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.cp/static-method.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gdb/testsuite/gdb.cp/static-method.exp b/gdb/testsuite/gdb.cp/static-method.exp index 9867c2c..e4a767e 100644 --- a/gdb/testsuite/gdb.cp/static-method.exp +++ b/gdb/testsuite/gdb.cp/static-method.exp @@ -70,7 +70,7 @@ foreach test $methods { # with the filename pre-pended. gdb_test "list ${srcfile}:$test" $result gdb_test "list '${srcfile}:$test'" $result - gdb_test "list '${srcfile}':$test'" $result + gdb_test "list '${srcfile}':'$test'" $result gdb_test "list ${srcfile}:'$test'" $result # Test setting and hitting a breakoint at the function/method. -- 1.7.6