From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [3/4] RFC: add missing quote to test
Date: Mon, 18 Jul 2011 15:33:00 -0000 [thread overview]
Message-ID: <m34o2j8vt4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4E20860A.9020402@redhat.com> (Keith Seitz's message of "Fri, 15 Jul 2011 11:25:14 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> On 07/15/2011 11:08 AM, Tom Tromey wrote:
Tom> Note the unpaired single quote in the test name.
Keith> Yeah, that's clearly a mistake.
Thanks. I'm checking this in now.
Tom> I don't know why this works without -gdwarf-4. I think it is a test
Tom> suite bug -- and in any case not something we want to bless by having it
Tom> in the test suite.
Keith> Using the same tree? That is unexpected. Otherwise, I could pretty
Keith> easily attribute this to linespec.c churn.
Yes, same tree:
make check RUNTESTFLAGS='--target_board unix/gdb:debug_flags=-gdwarf-4 static-method.exp'
[...]
FAIL: gdb.cp/static-method.exp: list 'static-method.cc':xxx::(anonymous namespace)::A::func'
# of expected passes 11
# of unexpected failures 1
make check RUNTESTFLAGS='static-method.exp'
# of expected passes 12
Tom
prev parent reply other threads:[~2011-07-18 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 18:15 Tom Tromey
2011-07-15 18:47 ` Keith Seitz
2011-07-18 15:33 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34o2j8vt4.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox