Should we fix warnings from GCC 2.xx?

Should we fix warnings from GCC 2.xx?

[Joel Brobecker]

While building GDB from CVS on my Linux machines, I saw a few warnings
like this one:

> tracepoint.c: In function `trace_find_tracepoint_command':
> tracepoint.c:2077: warning: suggest explicit braces to avoid ambiguous `else'

This warning appears with a GCC 2.8.1-based compiler, but does not
with GCC 3.0.4. Hence my question, do we want to fix these warnings
anyway?

I guess for a lot of warnings, the fix are quite straghtforward, like
this:
<<
Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.40
diff -c -3 -p -r1.40 tracepoint.c
*** tracepoint.c	24 Jul 2002 17:58:46 -0000	1.40
--- tracepoint.c	11 Sep 2002 23:33:52 -0000
*************** trace_find_tracepoint_command (char *arg
*** 2071,2080 ****
    if (target_is_remote ())
      {
        if (args == 0 || *args == 0)
! 	if (tracepoint_number == -1)
! 	  error ("No current tracepoint -- please supply an argument.");
! 	else
! 	  tdp = tracepoint_number;	/* default is current TDP */
        else
  	tdp = parse_and_eval_long (args);
  
--- 2071,2082 ----
    if (target_is_remote ())
      {
        if (args == 0 || *args == 0)
!         {
! 	    if (tracepoint_number == -1)
! 	      error ("No current tracepoint -- please supply an argument.");
! 	    else
! 	      tdp = tracepoint_number;	/* default is current TDP */
!         }
        else
  	tdp = parse_and_eval_long (args);
  
>>

-- 
Joel

Re: Should we fix warnings from GCC 2.xx?

[Andrew Cagney]

> While building GDB from CVS on my Linux machines, I saw a few warnings
> like this one:
> 
> 
>> tracepoint.c: In function `trace_find_tracepoint_command':
>> tracepoint.c:2077: warning: suggest explicit braces to avoid ambiguous `else'
> 
> 
> This warning appears with a GCC 2.8.1-based compiler, but does not
> with GCC 3.0.4. Hence my question, do we want to fix these warnings
> anyway?

Regardless, I don't see how it can hurt.  Removes the dangling `else' 
problem.

Andrew


> I guess for a lot of warnings, the fix are quite straghtforward, like
> this:
> <<
> Index: tracepoint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/tracepoint.c,v
> retrieving revision 1.40
> diff -c -3 -p -r1.40 tracepoint.c
> *** tracepoint.c	24 Jul 2002 17:58:46 -0000	1.40
> --- tracepoint.c	11 Sep 2002 23:33:52 -0000
> *************** trace_find_tracepoint_command (char *arg
> *** 2071,2080 ****
>     if (target_is_remote ())
>       {
>         if (args == 0 || *args == 0)
> ! 	if (tracepoint_number == -1)
> ! 	  error ("No current tracepoint -- please supply an argument.");
> ! 	else
> ! 	  tdp = tracepoint_number;	/* default is current TDP */
>         else
>   	tdp = parse_and_eval_long (args);
>   
> --- 2071,2082 ----
>     if (target_is_remote ())
>       {
>         if (args == 0 || *args == 0)
> !         {
> ! 	    if (tracepoint_number == -1)
> ! 	      error ("No current tracepoint -- please supply an argument.");
> ! 	    else
> ! 	      tdp = tracepoint_number;	/* default is current TDP */
> !         }
>         else
>   	tdp = parse_and_eval_long (args);
>   
> 
>>>
> 
> 
> -- Joel 

Re: Should we fix warnings from GCC 2.xx?

[Joel Brobecker]

> Regardless, I don't see how it can hurt.  Removes the dangling `else' 
> problem.

Ok, thanks for the clarification. I will check-in this patch shortly
and send the associated [PATCH] email as a confirmation. There is also
the exact same error in exec.c that I will fix.

-- 
Joel

Re: Should we fix warnings from GCC 2.xx?

[Eli Zaretskii]

On Wed, 11 Sep 2002, Joel Brobecker wrote:

> > tracepoint.c: In function `trace_find_tracepoint_command':
> > tracepoint.c:2077: warning: suggest explicit braces to avoid ambiguous `else'
> 
> This warning appears with a GCC 2.8.1-based compiler, but does not
> with GCC 3.0.4. Hence my question, do we want to fix these warnings
> anyway?

FWIW, I'm still using GCC 2.7.2.1 on one of my machines.

Re: Should we fix warnings from GCC 2.xx?

[Andreas Schwab]

Eli Zaretskii <eliz@is.elta.co.il> writes:

|> On Wed, 11 Sep 2002, Joel Brobecker wrote:
|> 
|> > > tracepoint.c: In function `trace_find_tracepoint_command':
|> > > tracepoint.c:2077: warning: suggest explicit braces to avoid ambiguous `else'
|> > 
|> > This warning appears with a GCC 2.8.1-based compiler, but does not
|> > with GCC 3.0.4. Hence my question, do we want to fix these warnings
|> > anyway?

GCC 2.8 warns in one case where GCC 2.95+ does not:

    if (foo)
      if (bar)
        ;
      else
        ;
    else
      ;

|> FWIW, I'm still using GCC 2.7.2.1 on one of my machines.

GCC 2.7 does not have this warning in the first place.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Should we fix warnings from GCC 2.xx?

[Eli Zaretskii]

On Thu, 19 Sep 2002, Andreas Schwab wrote:

> |> FWIW, I'm still using GCC 2.7.2.1 on one of my machines.
> 
> GCC 2.7 does not have this warning in the first place.

IIRC, it does.

Re: Should we fix warnings from GCC 2.xx?

[Andreas Schwab]

Eli Zaretskii <eliz@is.elta.co.il> writes:

|> On Thu, 19 Sep 2002, Andreas Schwab wrote:
|> 
|> > |> FWIW, I'm still using GCC 2.7.2.1 on one of my machines.
|> > 
|> > GCC 2.7 does not have this warning in the first place.
|> 
|> IIRC, it does.

It does have -Wparentheses, but it doesn't warn about braces.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."