Re: Should we fix warnings from GCC 2.xx?

[Andrew Cagney <ac131313@ges.redhat.com>]

> While building GDB from CVS on my Linux machines, I saw a few warnings
> like this one:
> 
> 
>> tracepoint.c: In function `trace_find_tracepoint_command':
>> tracepoint.c:2077: warning: suggest explicit braces to avoid ambiguous `else'
> 
> 
> This warning appears with a GCC 2.8.1-based compiler, but does not
> with GCC 3.0.4. Hence my question, do we want to fix these warnings
> anyway?

Regardless, I don't see how it can hurt.  Removes the dangling `else' 
problem.

Andrew


> I guess for a lot of warnings, the fix are quite straghtforward, like
> this:
> <<
> Index: tracepoint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/tracepoint.c,v
> retrieving revision 1.40
> diff -c -3 -p -r1.40 tracepoint.c
> *** tracepoint.c	24 Jul 2002 17:58:46 -0000	1.40
> --- tracepoint.c	11 Sep 2002 23:33:52 -0000
> *************** trace_find_tracepoint_command (char *arg
> *** 2071,2080 ****
>     if (target_is_remote ())
>       {
>         if (args == 0 || *args == 0)
> ! 	if (tracepoint_number == -1)
> ! 	  error ("No current tracepoint -- please supply an argument.");
> ! 	else
> ! 	  tdp = tracepoint_number;	/* default is current TDP */
>         else
>   	tdp = parse_and_eval_long (args);
>   
> --- 2071,2082 ----
>     if (target_is_remote ())
>       {
>         if (args == 0 || *args == 0)
> !         {
> ! 	    if (tracepoint_number == -1)
> ! 	      error ("No current tracepoint -- please supply an argument.");
> ! 	    else
> ! 	      tdp = tracepoint_number;	/* default is current TDP */
> !         }
>         else
>   	tdp = parse_and_eval_long (args);
>   
> 
>>>
> 
> 
> -- Joel