From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15520 invoked by alias); 11 Sep 2002 23:43:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15511 invoked from network); 11 Sep 2002 23:43:21 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 11 Sep 2002 23:43:21 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id A0DC0D2CC1; Wed, 11 Sep 2002 16:43:19 -0700 (PDT) Date: Wed, 11 Sep 2002 16:43:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Should we fix warnings from GCC 2.xx? Message-ID: <20020911234319.GN1105@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2002-09/txt/msg00197.txt.bz2 While building GDB from CVS on my Linux machines, I saw a few warnings like this one: > tracepoint.c: In function `trace_find_tracepoint_command': > tracepoint.c:2077: warning: suggest explicit braces to avoid ambiguous `else' This warning appears with a GCC 2.8.1-based compiler, but does not with GCC 3.0.4. Hence my question, do we want to fix these warnings anyway? I guess for a lot of warnings, the fix are quite straghtforward, like this: << Index: tracepoint.c =================================================================== RCS file: /cvs/src/src/gdb/tracepoint.c,v retrieving revision 1.40 diff -c -3 -p -r1.40 tracepoint.c *** tracepoint.c 24 Jul 2002 17:58:46 -0000 1.40 --- tracepoint.c 11 Sep 2002 23:33:52 -0000 *************** trace_find_tracepoint_command (char *arg *** 2071,2080 **** if (target_is_remote ()) { if (args == 0 || *args == 0) ! if (tracepoint_number == -1) ! error ("No current tracepoint -- please supply an argument."); ! else ! tdp = tracepoint_number; /* default is current TDP */ else tdp = parse_and_eval_long (args); --- 2071,2082 ---- if (target_is_remote ()) { if (args == 0 || *args == 0) ! { ! if (tracepoint_number == -1) ! error ("No current tracepoint -- please supply an argument."); ! else ! tdp = tracepoint_number; /* default is current TDP */ ! } else tdp = parse_and_eval_long (args); >> -- Joel