[patch/doc] ptid from core section

[patch/doc] ptid from core section

[Aleksandar Ristovski]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hello,

Providing 
http://sourceware.org/ml/gdb-patches/2009-06/msg00079.html 
gets approved, this patch adds a clue about new callbacks in 
internal gdb documentation.

Thanks,

-- 
Aleksandar Ristovski
QNX Software Systems


* doc/gdbinit.texinfo (Adding support for debugging core files):
Add information about ptid_from_core_section_name and
core_section_name_from_ptid.


[-- Attachment #2: corelow.c-pid-from-section-doc-20090604.diff --]
[-- Type: text/x-patch, Size: 814 bytes --]

Index: gdb/doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.303
diff -u -p -r1.303 gdbint.texinfo
--- gdb/doc/gdbint.texinfo	7 May 2009 18:40:43 -0000	1.303
+++ gdb/doc/gdbint.texinfo	4 Jun 2009 16:15:09 -0000
@@ -4429,7 +4429,9 @@ The prerequisite for adding core file su
 core file support in BFD.
 
 Once BFD support is available, writing the apropriate
-@code{regset_from_core_section} architecture function should be all
+@code{regset_from_core_section} and optionally
+@code{ptid_from_core_section_name} and @code{core_section_name_from_ptid}
+architecture functions should be all
 that is needed in order to add support for core files in @value{GDBN}.
 
 @node Defining Other Architecture Features 

Re: [patch/doc] ptid from core section

[Eli Zaretskii]

> From:  Aleksandar Ristovski <aristovski@qnx.com>
> Date:  Fri, 05 Jun 2009 09:09:34 -0400
> 
> Providing 
> http://sourceware.org/ml/gdb-patches/2009-06/msg00079.html 
> gets approved, this patch adds a clue about new callbacks in 
> internal gdb documentation.

Thanks.  However,

>  Once BFD support is available, writing the apropriate
> -@code{regset_from_core_section} architecture function should be all
> +@code{regset_from_core_section} and optionally
> +@code{ptid_from_core_section_name} and @code{core_section_name_from_ptid}
> +architecture functions should be all
>  that is needed in order to add support for core files in @value{GDBN}.

this say that the latter two APIs are optional, but does not say a
word when would the programmer want to define these optional APIs and
what would she lose if she doesn't.  Can you find a concise way of
saying that without getting into too elaborate details?

Re: [patch/doc] ptid from core section

[Aleksandar Ristovski]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

Eli Zaretskii wrote:
>> From:  Aleksandar Ristovski <aristovski@qnx.com>
>> Date:  Fri, 05 Jun 2009 09:09:34 -0400
>>
>> Providing 
>> http://sourceware.org/ml/gdb-patches/2009-06/msg00079.html 
>> gets approved, this patch adds a clue about new callbacks in 
>> internal gdb documentation.
> 
> Thanks.  However,
> 
>>  Once BFD support is available, writing the apropriate
>> -@code{regset_from_core_section} architecture function should be all
>> +@code{regset_from_core_section} and optionally
>> +@code{ptid_from_core_section_name} and @code{core_section_name_from_ptid}
>> +architecture functions should be all
>>  that is needed in order to add support for core files in @value{GDBN}.
> 
> this say that the latter two APIs are optional, but does not say a
> word when would the programmer want to define these optional APIs and
> what would she lose if she doesn't.  Can you find a concise way of
> saying that without getting into too elaborate details?
> 

Here is my attempt to do that.


-- 
Aleksandar Ristovski
QNX Software Systems

ChangeLog the same:


	* doc/gdbinit.texinfo (Adding support for debugging core 
files):
	Add information about ptid_from_core_section_name and
	core_section_name_from_ptid.


[-- Attachment #2: corelow.c-pid-from-section-doc-20090605.diff --]
[-- Type: text/x-patch, Size: 915 bytes --]

Index: gdb/doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.303
diff -u -p -r1.303 gdbint.texinfo
--- gdb/doc/gdbint.texinfo	7 May 2009 18:40:43 -0000	1.303
+++ gdb/doc/gdbint.texinfo	5 Jun 2009 15:34:43 -0000
@@ -4431,6 +4431,10 @@ core file support in BFD.
 Once BFD support is available, writing the apropriate
 @code{regset_from_core_section} architecture function should be all
 that is needed in order to add support for core files in @value{GDBN}.
+In cases where thread (or lwp depending on the system) numbers are not
+simply appended to appropriate @code{.reg/}
+section name, one also needs to provide @code{ptid_from_core_section_name}
+and @code{core_section_name_from_ptid} architecture functions.
 
 @node Defining Other Architecture Features 
 @section Defining Other Architecture Features 

Re: [patch/doc] ptid from core section

[Eli Zaretskii]

> From:  Aleksandar Ristovski <aristovski@qnx.com>
> Date:  Fri, 05 Jun 2009 11:38:08 -0400
> 
>  Once BFD support is available, writing the apropriate
>  @code{regset_from_core_section} architecture function should be all
>  that is needed in order to add support for core files in @value{GDBN}.
> +In cases where thread (or lwp depending on the system) numbers are not
> +simply appended to appropriate @code{.reg/}
> +section name, one also needs to provide @code{ptid_from_core_section_name}
> +and @code{core_section_name_from_ptid} architecture functions.

Thanks, this is fine with me.