From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13383 invoked by alias); 5 Jun 2009 15:38:39 -0000 Received: (qmail 13346 invoked by uid 22791); 5 Jun 2009 15:38:36 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Jun 2009 15:38:29 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MCbUs-0003dh-3x for gdb-patches@sources.redhat.com; Fri, 05 Jun 2009 15:38:22 +0000 Received: from mobius.qnx.com ([209.226.137.108]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Jun 2009 15:38:22 +0000 Received: from aristovski by mobius.qnx.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Jun 2009 15:38:22 +0000 To: gdb-patches@sources.redhat.com From: Aleksandar Ristovski Subject: Re: [patch/doc] ptid from core section Date: Fri, 05 Jun 2009 15:38:00 -0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050808030201080504020508" User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00100.txt.bz2 This is a multi-part message in MIME format. --------------050808030201080504020508 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1222 Eli Zaretskii wrote: >> From: Aleksandar Ristovski >> Date: Fri, 05 Jun 2009 09:09:34 -0400 >> >> Providing >> http://sourceware.org/ml/gdb-patches/2009-06/msg00079.html >> gets approved, this patch adds a clue about new callbacks in >> internal gdb documentation. > > Thanks. However, > >> Once BFD support is available, writing the apropriate >> -@code{regset_from_core_section} architecture function should be all >> +@code{regset_from_core_section} and optionally >> +@code{ptid_from_core_section_name} and @code{core_section_name_from_ptid} >> +architecture functions should be all >> that is needed in order to add support for core files in @value{GDBN}. > > this say that the latter two APIs are optional, but does not say a > word when would the programmer want to define these optional APIs and > what would she lose if she doesn't. Can you find a concise way of > saying that without getting into too elaborate details? > Here is my attempt to do that. -- Aleksandar Ristovski QNX Software Systems ChangeLog the same: * doc/gdbinit.texinfo (Adding support for debugging core files): Add information about ptid_from_core_section_name and core_section_name_from_ptid. --------------050808030201080504020508 Content-Type: text/x-patch; name="corelow.c-pid-from-section-doc-20090605.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="corelow.c-pid-from-section-doc-20090605.diff" Content-length: 915 Index: gdb/doc/gdbint.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v retrieving revision 1.303 diff -u -p -r1.303 gdbint.texinfo --- gdb/doc/gdbint.texinfo 7 May 2009 18:40:43 -0000 1.303 +++ gdb/doc/gdbint.texinfo 5 Jun 2009 15:34:43 -0000 @@ -4431,6 +4431,10 @@ core file support in BFD. Once BFD support is available, writing the apropriate @code{regset_from_core_section} architecture function should be all that is needed in order to add support for core files in @value{GDBN}. +In cases where thread (or lwp depending on the system) numbers are not +simply appended to appropriate @code{.reg/} +section name, one also needs to provide @code{ptid_from_core_section_name} +and @code{core_section_name_from_ptid} architecture functions. @node Defining Other Architecture Features @section Defining Other Architecture Features --------------050808030201080504020508--