Re: [PATCH] gdb/testsuite: fix a few typos

[Tom de Vries <tdevries@suse.de>]

On 12/1/25 6:37 PM, Simon Marchi wrote:
> 
> 
> On 2025-12-01 12:27, Tom de Vries wrote:
>> On 12/1/25 6:16 PM, Simon Marchi wrote:
>>> On 2025-12-01 12:12, Tom de Vries wrote:
>>>> Interesting.
>>>>
>>>> I wonder if that will still work with my proposal for moving the
>>>> commit-log check from the commit-msg to the post-commit stage (
>>>> https://sourceware.org/pipermail/gdb-patches/2025-December/223036.html
>>>> ), in which case the commit message is produced by a wrapper script,
>>>> and not by git as is the case for the commit-msg stage.
>>>
>>> Depends, what do you mean by "will still work"?
>>
>> Well, in the commit-msg stage, git will provide a file to the pre-commit hook containing the commit message.
>>
>> In the post-commit stage, git doesn't provide such a file, and the pre-commit calls a wrapper script which call git to generate the commit message.  So my question is whether the alias (shell alias or git alias?) will be active in this scenario or not.
> 
> It's still not clear to me which part you wonder will still work.  The
> part where codespell checks the patch diff that happened to be in my
> editor?

Yes.

>  If so, it's not a problem, it wasn't intended to work this way
> anyway.
> 

Right, but since you mentioned it, it could have been something you 
started to rely on.

I was wondering if we should make it work, running codespell on commits, 
while we don't have a clean state to run it on all files.  But I'm not 
sure yet if it's worth the effort.

> They are shell aliases:
> 
> $ alias gc gc!
> gc='git commit --verbose'
> 'gc!'='git commit --verbose --amend'
> 

I see, those won't interfere with calling git show, it's clear to me now.

Thanks,
- Tom

> from oh-my-zsh:
> 
> https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/git
> 
> You can define the same aliases if you want to try it yourself.
> 
> Simon