From: Tom de Vries <tdevries@suse.de>
To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: fix a few typos
Date: Fri, 28 Nov 2025 11:19:53 +0100 [thread overview]
Message-ID: <195c97cd-6d7d-47b2-a5b6-dc57c65e0679@suse.de> (raw)
In-Reply-To: <20251124215409.3761464-1-simon.marchi@polymtl.ca>
On 11/24/25 10:54 PM, simon.marchi@polymtl.ca wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> When merging the big "whitespace fix" commit in a downstream repo,
> pre-commit/codespell identified a lot of typos, fix a few of them.
>
Hi Simon,
LGTM.
Approved-By: Tom de Vries <tdevries@suse.de>
I wonder though about the setup you mention. Our pre-commit/codespell
setup in .pre-commit-config.yaml excludes the files you mention below,
so do you have some alternative/additional pre-commit setup in that
downstream repo?
Thanks,
- Tom
> Change-Id: Ie898e9903daa4e6e0e49a623891a739071e91392
> ---
> gdb/testsuite/gdb.base/ctf-ptype.exp | 2 +-
> gdb/testsuite/gdb.base/fileio.c | 12 +++----
> gdb/testsuite/gdb.base/ptype.exp | 2 +-
> .../gdb.dwarf2/ada-valprint-error.exp | 2 +-
> gdb/testsuite/gdb.dwarf2/dw2-fixed-point.exp | 2 +-
> gdb/testsuite/gdb.python/py-explore.exp | 32 +++++++++----------
> gdb/testsuite/lib/gdb.exp | 2 +-
> 7 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.base/ctf-ptype.exp b/gdb/testsuite/gdb.base/ctf-ptype.exp
> index 8baefdc005eb..daa9283775e8 100644
> --- a/gdb/testsuite/gdb.base/ctf-ptype.exp
> +++ b/gdb/testsuite/gdb.base/ctf-ptype.exp
> @@ -207,7 +207,7 @@ gdb_test "ptype the_highest" \
> "type = struct highest \{.*\[\r\n\] *int a;.*\[\r\n\] *struct \{.*\[\r\n\] *int b;.*\[\r\n\] *struct \{\.\.\.\} anonymous_level_2;.*\[\r\n\] *\} anonymous_level_1;.*\[\r\n\]}.*" \
> "ptype the_highest"
>
> -# Print the type descrption for one of the fields of variable the_highest.
> +# Print the type description for one of the fields of variable the_highest.
> # The purpose is to verify that the type of a field that was printed above
> # as "struct {...}" is now printed in a more descriptive way (because the
> # nesting level is now one level less).
> diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
> index 37337ef41e77..0ef85a26bee5 100644
> --- a/gdb/testsuite/gdb.base/fileio.c
> +++ b/gdb/testsuite/gdb.base/fileio.c
> @@ -65,7 +65,7 @@ static const char *strerrno (int err);
> /* Note that OUTDIR is defined by the test suite. */
> #define FILENAME "foo.fileio.test"
> #define RENAMED "bar.fileio.test"
> -#define NONEXISTANT "nofoo.fileio.test"
> +#define NONEXISTENT "nofoo.fileio.test"
> #define NOWRITE "nowrt.fileio.test"
> #define TESTDIR1 "dir1.fileio.test"
> #define TESTDIR2 "dir2.fileio.test"
> @@ -115,7 +115,7 @@ test_open (void)
> stop ();
> /* Opening nonexistant file */
> errno = 0;
> - ret = open (NONEXISTANT, O_RDONLY);
> + ret = open (NONEXISTENT, O_RDONLY);
> printf ("open 4: ret = %d, errno = %d %s\n", ret, errno,
> strerrno (errno));
> if (ret >= 0)
> @@ -311,9 +311,9 @@ test_stat (void)
> printf ("stat 3: ret = %d, errno = %d %s\n", ret, errno,
> strerrno (errno));
> stop ();
> - /* Nonexistant file */
> + /* Nonexistent file */
> errno = 0;
> - ret = stat (NONEXISTANT, &st);
> + ret = stat (NONEXISTENT, &st);
> printf ("stat 4: ret = %d, errno = %d %s\n", ret, errno,
> strerrno (errno));
> stop ();
> @@ -459,7 +459,7 @@ test_rename (void)
> stop ();
> /* oldpath does not exist */
> errno = 0;
> - ret = rename (OUTDIR NONEXISTANT, OUTDIR FILENAME);
> + ret = rename (OUTDIR NONEXISTENT, OUTDIR FILENAME);
> printf ("rename 5: ret = %d, errno = %d %s\n", ret, errno,
> strerrno (errno));
> stop ();
> @@ -501,7 +501,7 @@ test_unlink (void)
> stop ();
> /* pathname doesn't exist */
> errno = 0;
> - ret = unlink (OUTDIR NONEXISTANT);
> + ret = unlink (OUTDIR NONEXISTENT);
> printf ("unlink 3: ret = %d, errno = %d %s\n", ret, errno,
> strerrno (errno));
> stop ();
> diff --git a/gdb/testsuite/gdb.base/ptype.exp b/gdb/testsuite/gdb.base/ptype.exp
> index cf28aea2f51e..ae52d1b2ef0e 100644
> --- a/gdb/testsuite/gdb.base/ptype.exp
> +++ b/gdb/testsuite/gdb.base/ptype.exp
> @@ -499,7 +499,7 @@ gdb_test "ptype nested_su.inner_union_instance" "type = union inner_union \{.*\[
> gdb_test "ptype the_highest" \
> "type = struct highest \{.*\[\r\n\] *int a;.*\[\r\n\] *struct \{.*\[\r\n\] *int b;.*\[\r\n\] *struct \{\.\.\.\} anonymous_level_2;.*\[\r\n\] *\} anonymous_level_1;.*\[\r\n\]}.*"
>
> -# Print the type descrption for one of the fields of variable the_highest.
> +# Print the type description for one of the fields of variable the_highest.
> # The purpose is to verify that the type of a field that was printed above
> # as "struct {...}" is now printed in a more descriptive way (because the
> # nesting level is now one level less).
> diff --git a/gdb/testsuite/gdb.dwarf2/ada-valprint-error.exp b/gdb/testsuite/gdb.dwarf2/ada-valprint-error.exp
> index 1bc9fbde643d..05b5752324f7 100644
> --- a/gdb/testsuite/gdb.dwarf2/ada-valprint-error.exp
> +++ b/gdb/testsuite/gdb.dwarf2/ada-valprint-error.exp
> @@ -45,7 +45,7 @@ Dwarf::assemble $asm_file {
> set ptr_size [get_sizeof "void *" 96]
> set int_size [get_sizeof "int" 4]
>
> - # A structure with no size attribute, to mimick structures
> + # A structure with no size attribute, to mimic structures
> # in Ada that have a dynamic size...
> array_elt_label: structure_type {
> DW_AT_name fd__Tints_doubledC
> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-fixed-point.exp b/gdb/testsuite/gdb.dwarf2/dw2-fixed-point.exp
> index cbffbba01dac..d4f49a779119 100644
> --- a/gdb/testsuite/gdb.dwarf2/dw2-fixed-point.exp
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-fixed-point.exp
> @@ -207,7 +207,7 @@ gdb_test "print pck.fp1_var >= pck.fp1_var" \
> gdb_test "print pck.fp1_var >= pck.fp1_var2" \
> " = false"
>
> -# Same as above, but with litterals...
> +# Same as above, but with literals...
>
> gdb_test "print pck.fp1_var = 0.25" \
> " = true"
> diff --git a/gdb/testsuite/gdb.python/py-explore.exp b/gdb/testsuite/gdb.python/py-explore.exp
> index 3d948d64bbc7..102355e8a552 100644
> --- a/gdb/testsuite/gdb.python/py-explore.exp
> +++ b/gdb/testsuite/gdb.python/py-explore.exp
> @@ -263,9 +263,9 @@ gdb_test "explore int" ".*[scalar_type_decsription {int}].*"
> gdb_test_multiple "explore struct SimpleStruct" "" {
> -re ".*[compound_type_description $SS {struct/class}].*$SS_fields_types.*" {
> pass "explore struct SimpleStruct"
> - gdb_test_multiple "0" "explore type struct SimpleStruct feild 0" {
> + gdb_test_multiple "0" "explore type struct SimpleStruct field 0" {
> -re ".*[child_scalar_type_description {field 'a' of 'struct SimpleStruct'} {int}].*" {
> - pass "explore type struct SimpleStruct feild 0"
> + pass "explore type struct SimpleStruct field 0"
> gdb_test_multiple "\0" "return to struct SimpleStruct from field 0" {
> -re ".*[compound_type_description $SS {struct/class}].*$SS_fields_types.*" {
> pass "return to struct SimpleStruct from field 0"
> @@ -273,9 +273,9 @@ gdb_test_multiple "explore struct SimpleStruct" "" {
> }
> }
> }
> - gdb_test_multiple "1" "explore type struct SimpleStruct feild 1" {
> + gdb_test_multiple "1" "explore type struct SimpleStruct field 1" {
> -re ".*[child_scalar_type_description {field 'd' of 'struct SimpleStruct'} {double}].*" {
> - pass "explore type struct SimpleStruct feild 1"
> + pass "explore type struct SimpleStruct field 1"
> gdb_test_multiple "\0" "return to struct SimpleStruct from field 1" {
> -re ".*[compound_type_description $SS {struct/class}].*$SS_fields_types.*" {
> pass "return to struct SimpleStruct from field 1"
> @@ -294,9 +294,9 @@ gdb_test_multiple "explore struct SimpleStruct" "" {
> gdb_test_multiple "explore union SimpleUnion" "" {
> -re ".*[compound_type_description $SU {union}].*$SU_fields_types.*" {
> pass "explore union SimpleUnion"
> - gdb_test_multiple "0" "explore type union SimpleUnion feild 0" {
> + gdb_test_multiple "0" "explore type union SimpleUnion field 0" {
> -re ".*[child_scalar_type_description {field 'i' of 'union SimpleUnion'} {int}].*" {
> - pass "explore type union SimpleUnion feild 0"
> + pass "explore type union SimpleUnion field 0"
> gdb_test_multiple "\0" "return to union SimpleUnion from field 0" {
> -re ".*[compound_type_description $SU {union}].*$SU_fields_types.*" {
> pass "return to union SimpleUnion from field 0"
> @@ -304,9 +304,9 @@ gdb_test_multiple "explore union SimpleUnion" "" {
> }
> }
> }
> - gdb_test_multiple "1" "explore type union SimpleUnion feild 1" {
> + gdb_test_multiple "1" "explore type union SimpleUnion field 1" {
> -re ".*[child_scalar_type_description {field 'c' of 'union SimpleUnion'} {char}].*" {
> - pass "explore type union SimpleUnion feild 1"
> + pass "explore type union SimpleUnion field 1"
> gdb_test_multiple "\0" "return to union SimpleUnion from field 1" {
> -re ".*[compound_type_description $SU {union}].*$SU_fields_types.*" {
> pass "return to union SimpleUnion from field 1"
> @@ -314,9 +314,9 @@ gdb_test_multiple "explore union SimpleUnion" "" {
> }
> }
> }
> - gdb_test_multiple "2" "explore type union SimpleUnion feild 2" {
> + gdb_test_multiple "2" "explore type union SimpleUnion field 2" {
> -re ".*[child_scalar_type_description {field 'f' of 'union SimpleUnion'} {float}].*" {
> - pass "explore type union SimpleUnion feild 2"
> + pass "explore type union SimpleUnion field 2"
> gdb_test_multiple "\0" "return to union SimpleUnion from field 2" {
> -re ".*[compound_type_description $SU {union}].*$SU_fields_types.*" {
> pass "return to union SimpleUnion from field 2"
> @@ -324,9 +324,9 @@ gdb_test_multiple "explore union SimpleUnion" "" {
> }
> }
> }
> - gdb_test_multiple "3" "explore type union SimpleUnion feild 3" {
> + gdb_test_multiple "3" "explore type union SimpleUnion field 3" {
> -re ".*[child_scalar_type_description {field 'd' of 'union SimpleUnion'} {double}].*" {
> - pass "explore type union SimpleUnion feild 3"
> + pass "explore type union SimpleUnion field 3"
> gdb_test_multiple "\0" "return to union SimpleUnion from field 3" {
> -re ".*[compound_type_description $SU {union}].*$SU_fields_types.*" {
> pass "return to union SimpleUnion from field 3"
> @@ -345,9 +345,9 @@ gdb_test_multiple "explore union SimpleUnion" "" {
> gdb_test_multiple "explore SS" "" {
> -re ".*[typedef_type_description {SS} $SS].*[compound_type_description {SS} {struct/class}].*$SS_fields_types.*" {
> pass "explore SS"
> - gdb_test_multiple "0" "explore type SS feild 0" {
> + gdb_test_multiple "0" "explore type SS field 0" {
> -re ".*[child_scalar_type_description {field 'a' of 'SS'} {int}].*" {
> - pass "explore type SS feild 0"
> + pass "explore type SS field 0"
> gdb_test_multiple "\0" "return to SS from field 0" {
> -re ".*[compound_type_description {SS} {struct/class}].*$SS_fields_types.*" {
> pass "return to SS from field 0"
> @@ -355,9 +355,9 @@ gdb_test_multiple "explore SS" "" {
> }
> }
> }
> - gdb_test_multiple "1" "explore type SS feild 1" {
> + gdb_test_multiple "1" "explore type SS field 1" {
> -re ".*[child_scalar_type_description {field 'd' of 'SS'} {double}].*" {
> - pass "explore type SS feild 1"
> + pass "explore type SS field 1"
> gdb_test_multiple "\0" "return to struct SimpleStruct from field 1" {
> -re ".*[compound_type_description {SS} {struct/class}].*$SS_fields_types.*" {
> pass "return to SS field 1"
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 82bb511bccc9..366eff3ca329 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -6425,7 +6425,7 @@ proc gdb_compile {source dest type options} {
> }
> } elseif { $opt == "column-info" } {
> # If GCC or clang does not support column-info, compilation
> - # will fail and the usupported column-info option will be
> + # will fail and the unsupported column-info option will be
> # reported as such.
> if {[test_compiler_info {gcc-*}]} {
> lappend new_options "additional_flags=-gcolumn-info"
>
> base-commit: 500806dc2a341c0f2e36baf5a379a0b578b2ee2f
next prev parent reply other threads:[~2025-11-28 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 21:54 simon.marchi
2025-11-28 10:19 ` Tom de Vries [this message]
2025-11-28 15:40 ` Simon Marchi
2025-12-01 17:12 ` Tom de Vries
2025-12-01 17:16 ` Simon Marchi
2025-12-01 17:27 ` Tom de Vries
2025-12-01 17:37 ` Simon Marchi
2025-12-02 8:07 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=195c97cd-6d7d-47b2-a5b6-dc57c65e0679@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox