Re: [PATCH] gdb/testsuite: fix a few typos

[Tom de Vries <tdevries@suse.de>]

On 11/28/25 4:40 PM, Simon Marchi wrote:
> 
> 
> On 2025-11-28 05:19, Tom de Vries wrote:
>> On 11/24/25 10:54 PM, simon.marchi@polymtl.ca wrote:
>>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>>
>>> When merging the big "whitespace fix" commit in a downstream repo,
>>> pre-commit/codespell identified a lot of typos, fix a few of them.
>>>
>>
>> Hi Simon,
>>
>> LGTM.
>>
>> Approved-By: Tom de Vries <tdevries@suse.de>
> 
> Thanks, will push.
> 
>> I wonder though about the setup you mention.  Our pre-commit/codespell
>> setup in .pre-commit-config.yaml excludes the files you mention below,
>> so do you have some alternative/additional pre-commit setup in that
>> downstream repo?
> 
> I use aliases for git commit that use --verbose, causing the diff of the
> patch to be included in .git/COMMIT_EDITMSG while you write the commit
> message.  I guess that those words get checked by codespell (while it
> checks the commit message).

Interesting.

I wonder if that will still work with my proposal for moving the 
commit-log check from the commit-msg to the post-commit stage ( 
https://sourceware.org/pipermail/gdb-patches/2025-December/223036.html 
), in which case the commit message is produced by a wrapper script, and 
not by git as is the case for the commit-msg stage.

Also I wonder, don't you get warnings for removed lines in the scenario 
you describe?

Thanks,
- Tom