Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: fix a few typos
Date: Fri, 28 Nov 2025 10:40:08 -0500	[thread overview]
Message-ID: <7144681c-8584-4b84-a030-a2ad587b60d3@polymtl.ca> (raw)
In-Reply-To: <195c97cd-6d7d-47b2-a5b6-dc57c65e0679@suse.de>



On 2025-11-28 05:19, Tom de Vries wrote:
> On 11/24/25 10:54 PM, simon.marchi@polymtl.ca wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> When merging the big "whitespace fix" commit in a downstream repo,
>> pre-commit/codespell identified a lot of typos, fix a few of them.
>>
> 
> Hi Simon,
> 
> LGTM.
> 
> Approved-By: Tom de Vries <tdevries@suse.de>

Thanks, will push.

> I wonder though about the setup you mention.  Our pre-commit/codespell
> setup in .pre-commit-config.yaml excludes the files you mention below,
> so do you have some alternative/additional pre-commit setup in that
> downstream repo?

I use aliases for git commit that use --verbose, causing the diff of the
patch to be included in .git/COMMIT_EDITMSG while you write the commit
message.  I guess that those words get checked by codespell (while it
checks the commit message).

Simon

  reply	other threads:[~2025-11-28 15:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 21:54 simon.marchi
2025-11-28 10:19 ` Tom de Vries
2025-11-28 15:40   ` Simon Marchi [this message]
2025-12-01 17:12     ` Tom de Vries
2025-12-01 17:16       ` Simon Marchi
2025-12-01 17:27         ` Tom de Vries
2025-12-01 17:37           ` Simon Marchi
2025-12-02  8:07             ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7144681c-8584-4b84-a030-a2ad587b60d3@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox