Re: [PATCH] gdb/testsuite: fix a few typos

[Tom de Vries <tdevries@suse.de>]

On 12/1/25 6:16 PM, Simon Marchi wrote:
> On 2025-12-01 12:12, Tom de Vries wrote:
>> Interesting.
>>
>> I wonder if that will still work with my proposal for moving the
>> commit-log check from the commit-msg to the post-commit stage (
>> https://sourceware.org/pipermail/gdb-patches/2025-December/223036.html
>> ), in which case the commit message is produced by a wrapper script,
>> and not by git as is the case for the commit-msg stage.
> 
> Depends, what do you mean by "will still work"?

Well, in the commit-msg stage, git will provide a file to the pre-commit 
hook containing the commit message.

In the post-commit stage, git doesn't provide such a file, and the 
pre-commit calls a wrapper script which call git to generate the commit 
message.  So my question is whether the alias (shell alias or git 
alias?) will be active in this scenario or not.

Thanks,
- Tom

> 
>> Also I wonder, don't you get warnings for removed lines in the
>> scenario you describe?
> 
> I don't recall, but it's possible that I get them and ignore them.
> 
> Simon