From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wbbUMcvMLWmkZAwAWB0awg (envelope-from ) for ; Mon, 01 Dec 2025 12:13:47 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q5BSE1lg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TdHIlcye; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yovTbUhR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8bwEjE1Y; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C52FD1E0B6; Mon, 01 Dec 2025 12:13:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3BF671E08D for ; Mon, 01 Dec 2025 12:13:47 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C191948FD85D for ; Mon, 1 Dec 2025 17:13:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C191948FD85D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q5BSE1lg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TdHIlcye; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yovTbUhR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8bwEjE1Y Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 1CAEF48FDB2F for ; Mon, 1 Dec 2025 17:12:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CAEF48FDB2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CAEF48FDB2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764609150; cv=none; b=mR07DDPDvloto3i/Kvzq9lCRxaRkuxYy/PvGinODy6xoCld+rRixMmqW8tAfeHUrF5ch3mDMCCV8MDxndjNXo06vucUOZKbPjv+ne4rVudMkhHfYvLBhDtkZVKP2PhkRz8d4iWcl51N2N752PFNLo/CththtpgFsqEhFTTcHu/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764609150; c=relaxed/simple; bh=YkWEjaYQ079vE5mCmUE2lYSemRQamdataLuRWUbZDok=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=QIo+X7mRaZfbbyn/ErVDZE/VvxCPRYhyOAhph9NdZMHeCd2WE3tQ29NF3kqkIcGQBZ2MBM0CEX7LH2/dUcZjVxMr7bYcJHl9Mb3PzrRoKVP60OVcsJx13PrARpKZMkYdRySJjoWflY7gKKPzNAtHu9cOLU0oz303MIbXt//sAaw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CAEF48FDB2F Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CB0065BCD9; Mon, 1 Dec 2025 17:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764609149; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6XvXqXS0Lh5lRRTbcKNMVkaXYMTqiJAHD8w9Iu4IrPc=; b=Q5BSE1lgIkwCai3s99xhErFYQbAZZJkwZNRK4ASba1DVEQl6Jg8iD1bBgqIsOrApkZ9CTu q87fOm1tGy2E+TQJckXqBxSpdQ7aiL5sFxt8l9Ya8UCSLNl5FkMxyq49ZhRRuDqbI36SNK I9moKcman46UTMzuznt35tEADsiijJs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764609149; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6XvXqXS0Lh5lRRTbcKNMVkaXYMTqiJAHD8w9Iu4IrPc=; b=TdHIlcyewOsU1aljBCJEz10ukDWOSA69HqS/76v47TPfjbK5gqa8d+bqDlvDf/f0xJuMAJ Ug5ZORwIb3/VoyCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764609148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6XvXqXS0Lh5lRRTbcKNMVkaXYMTqiJAHD8w9Iu4IrPc=; b=yovTbUhRVJjoMV5iaZODP/13sw0YOV79TSLWYDgw9rUkG019uHcZ3yETw4rms8kOp4nlxX +O85c/EiJX+I8/7QrBaP/z4pVrZvYplw82LX68k+OkCA4DNKlDE0aDJPjl+NAdZN+k+JRA Sls8rctZ+zOs5AHD+xtphKpyGIKxCGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764609148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6XvXqXS0Lh5lRRTbcKNMVkaXYMTqiJAHD8w9Iu4IrPc=; b=8bwEjE1YZ9Xll5iUepdSqE8ti5LpSngA8hPvG08t31bnJBEz5wLpLZ8q93gCDo8CgiUA9z wheU3H6DL/MOgUDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B5E743EA63; Mon, 1 Dec 2025 17:12:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Q3oqK3zMLWlFfwAAD6G6ig (envelope-from ); Mon, 01 Dec 2025 17:12:28 +0000 Message-ID: <7ead3569-5727-4f12-a9eb-40acf3193c3a@suse.de> Date: Mon, 1 Dec 2025 18:12:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: fix a few typos To: Simon Marchi , gdb-patches@sourceware.org References: <20251124215409.3761464-1-simon.marchi@polymtl.ca> <195c97cd-6d7d-47b2-a5b6-dc57c65e0679@suse.de> <7144681c-8584-4b84-a030-a2ad587b60d3@polymtl.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <7144681c-8584-4b84-a030-a2ad587b60d3@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.19)[-0.926]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:email, suse.de:mid, sourceware.org:url] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/28/25 4:40 PM, Simon Marchi wrote: > > > On 2025-11-28 05:19, Tom de Vries wrote: >> On 11/24/25 10:54 PM, simon.marchi@polymtl.ca wrote: >>> From: Simon Marchi >>> >>> When merging the big "whitespace fix" commit in a downstream repo, >>> pre-commit/codespell identified a lot of typos, fix a few of them. >>> >> >> Hi Simon, >> >> LGTM. >> >> Approved-By: Tom de Vries > > Thanks, will push. > >> I wonder though about the setup you mention. Our pre-commit/codespell >> setup in .pre-commit-config.yaml excludes the files you mention below, >> so do you have some alternative/additional pre-commit setup in that >> downstream repo? > > I use aliases for git commit that use --verbose, causing the diff of the > patch to be included in .git/COMMIT_EDITMSG while you write the commit > message. I guess that those words get checked by codespell (while it > checks the commit message). Interesting. I wonder if that will still work with my proposal for moving the commit-log check from the commit-msg to the post-commit stage ( https://sourceware.org/pipermail/gdb-patches/2025-December/223036.html ), in which case the commit message is produced by a wrapper script, and not by git as is the case for the commit-msg stage. Also I wonder, don't you get warnings for removed lines in the scenario you describe? Thanks, - Tom