From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CVTmJoGeLmnMHw8AWB0awg (envelope-from ) for ; Tue, 02 Dec 2025 03:08:33 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cCB/JtLs; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HNkEpKO4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NboiWNMV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=FL6WB054; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9A6E21E0B3; Tue, 02 Dec 2025 03:08:33 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E0EF91E048 for ; Tue, 02 Dec 2025 03:08:32 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D5F44BB3BC7 for ; Tue, 2 Dec 2025 08:08:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D5F44BB3BC7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cCB/JtLs; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HNkEpKO4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NboiWNMV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=FL6WB054 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 4302C4BB3BC5 for ; Tue, 2 Dec 2025 08:07:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4302C4BB3BC5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4302C4BB3BC5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764662860; cv=none; b=XMlvWxI3AJg34rqR7qFraGq/3xWwz0cmzySCMuEh+c1j2mEuvSdEFpGBqXJU5yBJ2WGM69p30cCyUeioYBoWXknH/6rXEX+mZi73YJLnVmQ8FZ4HrAv0OcEg2n6JWq4NOpBSDd210IukzhGIqHlneGySua6hLpLjXjSjY+Ftzds= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764662860; c=relaxed/simple; bh=Dg/ASMMF52XJYkNv9x4OBzJ2qwwGpr2lSMTzCCqvolI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=qyy1XFuH7k3D37T6WcAK7WRRsbJQCoAh1aQmsjorhtk5M/0CYHJP1uWI52cdXlvlG+FIAxdqTm+9bYOEqK5dPsgFKeNi0XYoxs1r1lZGjBJhIFs+CIf2aQz4LVZytI+mV5MMFOmWJyxw2+B8liVrIuK1X9Dq2P62EbZXtVQndTA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4302C4BB3BC5 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5297C5BD0E; Tue, 2 Dec 2025 08:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764662859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yTZjYJNQpS0m2Q28qZnPy8LrBh9psHIfXvHy+k69XQ8=; b=cCB/JtLsAoI9OvfBBp2xVBTe5cQilWrpFN2n+2nB3HeZVeDe0cJxyqjToTTGVtGm+N4Gfu e0aWGRhaFw5N181a0Aj3dZ5BiPWFMOt61E91pg1YfLD/Ijy+n6V8iK8kiM2qSPilhPflm4 pfhNPLXP/JekLK165p9STENAdbhPUL4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764662859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yTZjYJNQpS0m2Q28qZnPy8LrBh9psHIfXvHy+k69XQ8=; b=HNkEpKO4U9rAg6V31m883gEMrGBSkfUPyhb9VcTlzJirBbM/PmjkI7/JoMvf9sbJmzTe66 80nFvcrMLzKRSNBg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764662857; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yTZjYJNQpS0m2Q28qZnPy8LrBh9psHIfXvHy+k69XQ8=; b=NboiWNMVPWfSXaHSz1tnvNHMW9+w9wOWlYwRSqZTflWVruLpoIxdzD2NwZ6V2i51aywaw1 mOOz9eSRiw5FroU6MaiWUEpYOEAHuboKMIk5AE3RiS7ZAaatcWttStQyeQNpyavpJrwI58 SNquHjZSevYceC7G0IkeVnv4kov/SpY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764662857; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yTZjYJNQpS0m2Q28qZnPy8LrBh9psHIfXvHy+k69XQ8=; b=FL6WB054j5XFJhIGYp3bD7FpjNZG5kuSpCDHQhrjtoXr5NgZiwhdeBTFNdsunpIEQv5Dgq b48eNLWOahoaIFBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3B9D83EA63; Tue, 2 Dec 2025 08:07:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mYb8DEmeLmmXFwAAD6G6ig (envelope-from ); Tue, 02 Dec 2025 08:07:37 +0000 Message-ID: Date: Tue, 2 Dec 2025 09:07:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: fix a few typos To: Simon Marchi , gdb-patches@sourceware.org References: <20251124215409.3761464-1-simon.marchi@polymtl.ca> <195c97cd-6d7d-47b2-a5b6-dc57c65e0679@suse.de> <7144681c-8584-4b84-a030-a2ad587b60d3@polymtl.ca> <7ead3569-5727-4f12-a9eb-40acf3193c3a@suse.de> <97d882dc-025c-4bce-90e4-8fdeb805390d@polymtl.ca> <2924a089-07a2-4742-ba9f-a1ae409ed0dc@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.27 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.17)[-0.861]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/1/25 6:37 PM, Simon Marchi wrote: > > > On 2025-12-01 12:27, Tom de Vries wrote: >> On 12/1/25 6:16 PM, Simon Marchi wrote: >>> On 2025-12-01 12:12, Tom de Vries wrote: >>>> Interesting. >>>> >>>> I wonder if that will still work with my proposal for moving the >>>> commit-log check from the commit-msg to the post-commit stage ( >>>> https://sourceware.org/pipermail/gdb-patches/2025-December/223036.html >>>> ), in which case the commit message is produced by a wrapper script, >>>> and not by git as is the case for the commit-msg stage. >>> >>> Depends, what do you mean by "will still work"? >> >> Well, in the commit-msg stage, git will provide a file to the pre-commit hook containing the commit message. >> >> In the post-commit stage, git doesn't provide such a file, and the pre-commit calls a wrapper script which call git to generate the commit message. So my question is whether the alias (shell alias or git alias?) will be active in this scenario or not. > > It's still not clear to me which part you wonder will still work. The > part where codespell checks the patch diff that happened to be in my > editor? Yes. > If so, it's not a problem, it wasn't intended to work this way > anyway. > Right, but since you mentioned it, it could have been something you started to rely on. I was wondering if we should make it work, running codespell on commits, while we don't have a clean state to run it on all files. But I'm not sure yet if it's worth the effort. > They are shell aliases: > > $ alias gc gc! > gc='git commit --verbose' > 'gc!'='git commit --verbose --amend' > I see, those won't interfere with calling git show, it's clear to me now. Thanks, - Tom > from oh-my-zsh: > > https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/git > > You can define the same aliases if you want to try it yourself. > > Simon