Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
	"Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH V6 1/3] gdb: support for eBPF
Date: Wed, 5 Aug 2020 09:00:49 -0400	[thread overview]
Message-ID: <e743a918-e4db-16e7-3012-8af1deb63daf@simark.ca> (raw)
In-Reply-To: <20200805092112.GA853475@embecosm.com>

On 2020-08-05 5:21 a.m., Andrew Burgess wrote:
> I was thinking about this last night and I realised that "quality" was
> absolutely the wrong word for me to use, so I apologise for that.
> 
> The issue here is not what is good (or quality) vs bad, which is what
> I implied.  As you said, your code is perfectly valid C++.
> 
> What I should have said is that your preferences don't take precedent
> over the projects agreed coding standard.  There are many
> non-functional alternatives to the current coding standard, but
> people are not free to just go with their personal preferences.  We
> all stick to some agreed rules, and hopefully, over time we end up
> with a consistent looking code base.

I completely agree with you, in practice I just didn't want to enter an argument about it.

Simon


  reply	other threads:[~2020-08-05 13:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 14:02 [PATCH V6 0/3] eBPF support Jose E. Marchesi
2020-08-03 14:02 ` [PATCH V6 1/3] gdb: support for eBPF Jose E. Marchesi
2020-08-03 14:52   ` Eli Zaretskii
2020-08-03 15:04     ` Jose E. Marchesi
2020-08-03 14:55   ` Aktemur, Tankut Baris
2020-08-03 15:52     ` Jose E. Marchesi
2020-08-03 16:00       ` Simon Marchi
2020-08-03 16:46         ` Jose E. Marchesi
2020-08-04 13:41       ` Andrew Burgess
2020-08-04 14:57         ` Jose E. Marchesi
2020-08-04 16:29           ` Simon Marchi
2020-08-05  9:21           ` Andrew Burgess
2020-08-05 13:00             ` Simon Marchi [this message]
2020-08-03 14:02 ` [PATCH V6 2/3] sim: eBPF simulator Jose E. Marchesi
2020-08-04 14:50   ` Andrew Burgess
2020-08-04 15:32     ` Jose E. Marchesi
2020-08-03 14:02 ` [PATCH V6 3/3] sim: generated files for the " Jose E. Marchesi
2020-08-04 13:51   ` Andrew Burgess
2020-08-04 14:59     ` Jose E. Marchesi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e743a918-e4db-16e7-3012-8af1deb63daf@simark.ca \
    --to=simark@simark.ca \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jose.marchesi@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox