From: Simon Marchi <simark@simark.ca>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
Andrew Burgess <andrew.burgess@embecosm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH V6 1/3] gdb: support for eBPF
Date: Tue, 4 Aug 2020 12:29:35 -0400 [thread overview]
Message-ID: <52afe8b7-5f69-61df-68bc-737672167b54@simark.ca> (raw)
In-Reply-To: <87ft928nm8.fsf@oracle.com>
On 2020-08-04 10:57 a.m., Jose E. Marchesi via Gdb-patches wrote:
> I don't think anything in the proposed patch is invalid C++. I was just
> expressing a personal preference in style, call it Cish C++ if not C.
>
> Of course, if the global maintainers decide that "quality" C++ requires
> avoiding `struct' keywords and using nullptr instead of NULL, and that
> it is important for new code to stick to it, then sure I will just
> change it without further discussion :)
>
Like I said, I don't think it is something worth fighting over, because it's
not functional. I would be a bit more pushy when it gets to using unique_ptr
to memory management with error handling, using std::vector instead of a home
grown vector implementation, using inheritance instead of an array of function
pointers to implement a vtable, etc. Basically, anything for which C++ can
provide more safety.
Simon
next prev parent reply other threads:[~2020-08-04 16:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 14:02 [PATCH V6 0/3] eBPF support Jose E. Marchesi
2020-08-03 14:02 ` [PATCH V6 1/3] gdb: support for eBPF Jose E. Marchesi
2020-08-03 14:52 ` Eli Zaretskii
2020-08-03 15:04 ` Jose E. Marchesi
2020-08-03 14:55 ` Aktemur, Tankut Baris
2020-08-03 15:52 ` Jose E. Marchesi
2020-08-03 16:00 ` Simon Marchi
2020-08-03 16:46 ` Jose E. Marchesi
2020-08-04 13:41 ` Andrew Burgess
2020-08-04 14:57 ` Jose E. Marchesi
2020-08-04 16:29 ` Simon Marchi [this message]
2020-08-05 9:21 ` Andrew Burgess
2020-08-05 13:00 ` Simon Marchi
2020-08-03 14:02 ` [PATCH V6 2/3] sim: eBPF simulator Jose E. Marchesi
2020-08-04 14:50 ` Andrew Burgess
2020-08-04 15:32 ` Jose E. Marchesi
2020-08-03 14:02 ` [PATCH V6 3/3] sim: generated files for the " Jose E. Marchesi
2020-08-04 13:51 ` Andrew Burgess
2020-08-04 14:59 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52afe8b7-5f69-61df-68bc-737672167b54@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox