Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
	"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH V6 1/3] gdb: support for eBPF
Date: Mon, 3 Aug 2020 12:00:17 -0400	[thread overview]
Message-ID: <3c096b51-21f1-5286-69a1-dd24e3dc1ffe@simark.ca> (raw)
In-Reply-To: <87o8nrengw.fsf@oracle.com>

On 2020-08-03 11:52 a.m., Jose E. Marchesi via Gdb-patches wrote:
>> Just my two cents.  The 'struct' keyword can be removed in numerous places
>> throughout the file.  Also, NULL can be replaced with nullptr.
> I prefer to write (and maintain) C.
> 

Just pretend that you've done

typedef struct {
  ...
} foo;

instead of

struct foo
{
  ...
};

and there there is

#define nullptr NULL

:)

FWIW, I agree with Baris on that, but it's not something worth fighting over, especially
for tdep code.  As long as you maintain it, I think it's ok to have a bit of artistic
freedom.  For common code, we probably want to enforce a more consistent style though.

Simon


  reply	other threads:[~2020-08-03 16:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 14:02 [PATCH V6 0/3] eBPF support Jose E. Marchesi
2020-08-03 14:02 ` [PATCH V6 1/3] gdb: support for eBPF Jose E. Marchesi
2020-08-03 14:52   ` Eli Zaretskii
2020-08-03 15:04     ` Jose E. Marchesi
2020-08-03 14:55   ` Aktemur, Tankut Baris
2020-08-03 15:52     ` Jose E. Marchesi
2020-08-03 16:00       ` Simon Marchi [this message]
2020-08-03 16:46         ` Jose E. Marchesi
2020-08-04 13:41       ` Andrew Burgess
2020-08-04 14:57         ` Jose E. Marchesi
2020-08-04 16:29           ` Simon Marchi
2020-08-05  9:21           ` Andrew Burgess
2020-08-05 13:00             ` Simon Marchi
2020-08-03 14:02 ` [PATCH V6 2/3] sim: eBPF simulator Jose E. Marchesi
2020-08-04 14:50   ` Andrew Burgess
2020-08-04 15:32     ` Jose E. Marchesi
2020-08-03 14:02 ` [PATCH V6 3/3] sim: generated files for the " Jose E. Marchesi
2020-08-04 13:51   ` Andrew Burgess
2020-08-04 14:59     ` Jose E. Marchesi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c096b51-21f1-5286-69a1-dd24e3dc1ffe@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=jose.marchesi@oracle.com \
    --cc=tankut.baris.aktemur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox