From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 92D933858D35
 for <gdb-patches@sourceware.org>; Mon,  3 Aug 2020 16:00:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 92D933858D35
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id DF9CF1E5F9;
 Mon,  3 Aug 2020 12:00:18 -0400 (EDT)
Subject: Re: [PATCH V6 1/3] gdb: support for eBPF
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
 "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
References: <20200803140237.14476-1-jose.marchesi@oracle.com>
 <20200803140237.14476-2-jose.marchesi@oracle.com>
 <SN6PR11MB28934767080FF05DFE61C17FC44D0@SN6PR11MB2893.namprd11.prod.outlook.com>
 <87o8nrengw.fsf@oracle.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <3c096b51-21f1-5286-69a1-dd24e3dc1ffe@simark.ca>
Date: Mon, 3 Aug 2020 12:00:17 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <87o8nrengw.fsf@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2020 16:00:20 -0000

On 2020-08-03 11:52 a.m., Jose E. Marchesi via Gdb-patches wrote:
>> Just my two cents.  The 'struct' keyword can be removed in numerous places
>> throughout the file.  Also, NULL can be replaced with nullptr.
> I prefer to write (and maintain) C.
> 

Just pretend that you've done

typedef struct {
  ...
} foo;

instead of

struct foo
{
  ...
};

and there there is

#define nullptr NULL

:)

FWIW, I agree with Baris on that, but it's not something worth fighting over, especially
for tdep code.  As long as you maintain it, I think it's ok to have a bit of artistic
freedom.  For common code, we probably want to enforce a more consistent style though.

Simon