Re: [PATCH V6 1/3] gdb: support for eBPF

Simon Marchi
2020-08-04T16:29:44Z

On 2020-08-04 10:57 a.m., Jose E. Marchesi via Gdb-patches wrote:
> I don't think anything in the proposed patch is invalid C++. I was just
> expressing a personal preference in style, call it Cish C++ if not C.
>
> Of course, if the global maintainers decide that "quality" C++ requires
> avoiding `struct' keywords and using nullptr instead of NULL, and that
> it is important for new code to stick to it, then sure I will just
> change it without further discussion :)
>

Like I said, I don't think it is something worth fighting over, because it's
not functional. I would be a bit more pushy when it gets to using unique_ptr
to memory management with error handling, using std::vector instead of a home
grown vector implementation, using inheritance instead of an array of function
pointers to implement a vtable, etc. Basically, anything for which C++ can
provide more safety.

Simon