Re: [PATCH V6 1/3] gdb: support for eBPF

Eli Zaretskii
2020-08-03T14:52:28Z

> Date: Mon, 3 Aug 2020 16:02:35 +0200
> From: "Jose E. Marchesi via Gdb-patches" <gdb-patches@sourceware.org>
>
> This patch adds basic support for the eBPF target: tdep and build
> machinery. The accompanying simulator is introduced in subsequent
> patches.
>
> gdb/ChangeLog:
>
> 2020-08-03 Weimin Pan <weimin.pan@oracle.com>
> Jose E. Marchesi <jose.marchesi@oracle.com>
>
> * configure.tgt: Add entry for bpf-*-*.
> * Makefile.in (ALL_TARGET_OBS): Add bpf-tdep.o
> (ALLDEPFILES): Add bpf-tdep.c.
> * bpf-tdep.c: New file.
> * MAINTAINERS: Add bpf target and maintainer.
>
> gdb/doc/ChangeLog:
>
> 2020-08-03 Jose E. Marchesi <jose.marchesi@oracle.com>
>
> * gdb.texinfo (Contributors): Add information for the eBPF
> support.
> (BPF): New section.

Thanks.

> @@ -24381,6 +24385,7 @@ acceptable commands.
> @menu
> * ARC:: Synopsys ARC
> * ARM:: ARM
> +* BPF:: eBPF
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please don't use TABs in Texinfo sources.

Also, I think this should be called out in NEWS.

The documentation part is OK with these nits fixed.