From: Pedro Alves <palves@redhat.com>
To: Rich Felker <dalias@aerifal.cx>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
Romain Naour <romain.naour@smile.fr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Romain Naour <romain.naour@gmail.com>,
buildroot@buildroot.org, gdb-patches@sourceware.org
Subject: Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system
Date: Tue, 11 Sep 2018 16:04:00 -0000 [thread overview]
Message-ID: <e46a59e4-ea58-17ed-bfb0-f1a172c4af18@redhat.com> (raw)
In-Reply-To: <20180911141312.GU1878@brightrain.aerifal.cx>
On 09/11/2018 03:13 PM, Rich Felker wrote:
> As an aside, the whole idea of running in-process code
> referencing/using functions in the process being debugged (like stat
> in libc) seems fragile and broken; perhaps aside from this
> inadvertently-added use in is_regular_file, there is no such code in
> the IPA stuff?
There is (or there should be) no such code in the fast path, which is
actually collecting tracepoints -- there are no syscalls in that path.
If there were, the whole point of the IPA would be thrown out the window.
There's some in setup code, but it hasn't been problematic.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-09-11 16:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180909163750.14196-1-romain.naour@gmail.com>
[not found] ` <20180909163750.14196-2-romain.naour@gmail.com>
[not found] ` <20180910174900.0b9f4133@windsurf>
2018-09-10 21:21 ` Romain Naour
2018-09-10 22:41 ` Rich Felker
2018-09-11 0:38 ` Sergio Durigan Junior
2018-09-11 9:51 ` Pedro Alves
2018-09-11 14:13 ` Rich Felker
2018-09-11 16:04 ` Pedro Alves [this message]
2018-09-11 18:22 ` Sergio Durigan Junior
2018-09-12 15:26 ` Pedro Alves
2018-09-12 17:11 ` Sergio Durigan Junior
2018-09-12 17:40 ` Pedro Alves
2018-09-11 10:13 ` Pedro Alves
2018-09-11 6:47 ` Thomas Petazzoni
2018-09-12 17:31 ` [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c Sergio Durigan Junior
2018-09-12 17:41 ` Pedro Alves
2018-09-12 17:59 ` Sergio Durigan Junior
2018-09-14 21:27 ` Romain Naour
2018-09-14 21:41 ` Tom Tromey
2018-09-14 21:48 ` Sergio Durigan Junior
2018-09-14 21:55 ` Romain Naour
2018-09-14 22:09 ` Joel Brobecker
2018-09-15 13:16 ` Romain Naour
2018-09-15 13:28 ` Romain Naour
2018-09-15 20:42 ` Sergio Durigan Junior
2018-09-17 17:01 ` Joel Brobecker
2018-09-15 20:35 ` Sergio Durigan Junior
2018-09-15 21:14 ` Romain Naour
2018-09-16 4:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e46a59e4-ea58-17ed-bfb0-f1a172c4af18@redhat.com \
--to=palves@redhat.com \
--cc=buildroot@buildroot.org \
--cc=dalias@aerifal.cx \
--cc=gdb-patches@sourceware.org \
--cc=romain.naour@gmail.com \
--cc=romain.naour@smile.fr \
--cc=sergiodj@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox