From: Joel Brobecker <brobecker@adacore.com>
To: Romain Naour <romain.naour@smile.fr>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
Tom Tromey <tom@tromey.com>, Pedro Alves <palves@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>,
Rich Felker <dalias@aerifal.cx>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Romain Naour <romain.naour@gmail.com>
Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c
Date: Fri, 14 Sep 2018 22:09:00 -0000 [thread overview]
Message-ID: <20180914220940.GB26509@adacore.com> (raw)
In-Reply-To: <6e01d5ff-42bb-e1fc-162c-aa3fe97cf6b2@smile.fr>
Hello Romain,
> > Me too. I can backport it to 8.2 if wanted.
>
> Yes please for the upcoming 8.2.1.
Once a release has been made off a give branch, there are a couple
of additional conditions before we can backport that change to
that branch:
- The patch needs to be safe, and you need approval from a Global
Maintainer to do so;
I looked at the patch, and although I was nervous about
the removal of the <stat.h> #include at first, I checked
the contents of the file, and I am reasonably certain that
there isn't any other code that might needed on some obscure
system. So you have my OK for the patch to be backported to
the gdb-8.2-branch.
- And the commit should have a corresponding GDB PR number
(https://sourceware.org/bugzilla/); the PR number acts as
a reference for "what's changed" in each corrective release,
so the clearer the explanation in the description, the better.
If you are the one motivated for the backport, it would be
helpful if you could take care of creating the PR. Sergio
offered to then backport it for you, but I can also help
with that.
Thank you,
--
Joel
next prev parent reply other threads:[~2018-09-14 22:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180909163750.14196-1-romain.naour@gmail.com>
[not found] ` <20180909163750.14196-2-romain.naour@gmail.com>
[not found] ` <20180910174900.0b9f4133@windsurf>
2018-09-10 21:21 ` [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system Romain Naour
2018-09-10 22:41 ` Rich Felker
2018-09-11 0:38 ` Sergio Durigan Junior
2018-09-11 9:51 ` Pedro Alves
2018-09-11 14:13 ` Rich Felker
2018-09-11 16:04 ` Pedro Alves
2018-09-11 18:22 ` Sergio Durigan Junior
2018-09-12 15:26 ` Pedro Alves
2018-09-12 17:11 ` Sergio Durigan Junior
2018-09-12 17:40 ` Pedro Alves
2018-09-11 10:13 ` Pedro Alves
2018-09-11 6:47 ` Thomas Petazzoni
2018-09-12 17:31 ` [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c Sergio Durigan Junior
2018-09-12 17:41 ` Pedro Alves
2018-09-12 17:59 ` Sergio Durigan Junior
2018-09-14 21:27 ` Romain Naour
2018-09-14 21:41 ` Tom Tromey
2018-09-14 21:48 ` Sergio Durigan Junior
2018-09-14 21:55 ` Romain Naour
2018-09-14 22:09 ` Joel Brobecker [this message]
2018-09-15 13:16 ` Romain Naour
2018-09-15 13:28 ` Romain Naour
2018-09-15 20:42 ` Sergio Durigan Junior
2018-09-17 17:01 ` Joel Brobecker
2018-09-15 20:35 ` Sergio Durigan Junior
2018-09-15 21:14 ` Romain Naour
2018-09-16 4:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914220940.GB26509@adacore.com \
--to=brobecker@adacore.com \
--cc=dalias@aerifal.cx \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=romain.naour@gmail.com \
--cc=romain.naour@smile.fr \
--cc=sergiodj@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox