From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Cc: Rich Felker <dalias@aerifal.cx>,
Romain Naour <romain.naour@smile.fr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Romain Naour <romain.naour@gmail.com>
Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c
Date: Wed, 12 Sep 2018 17:41:00 -0000 [thread overview]
Message-ID: <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com> (raw)
In-Reply-To: <20180912173113.2007-1-sergiodj@redhat.com>
On 09/12/2018 06:31 PM, Sergio Durigan Junior wrote:
> The most simple fix for this problem is to move 'is_regular_file' to
> 'filestuff.c', which is not used by IPA. This ends up making the
> files more logically organized as well, since 'is_regular_file' is a
> file operation.
>
> No regressions found.
>
> gdb/ChangeLog:
> 2018-09-12 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * common/common-utils.c: Don't include '<sys/stat.h>'.
> (is_regular_file): Move to...
> * common/filestuff.c (is_regular_file): ... here.
> * common/common-utils.h (is_regular_file): Move to...
> * common/filestuff.h (is_regular_file): ... here.
OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-09-12 17:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180909163750.14196-1-romain.naour@gmail.com>
[not found] ` <20180909163750.14196-2-romain.naour@gmail.com>
[not found] ` <20180910174900.0b9f4133@windsurf>
2018-09-10 21:21 ` [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system Romain Naour
2018-09-10 22:41 ` Rich Felker
2018-09-11 0:38 ` Sergio Durigan Junior
2018-09-11 9:51 ` Pedro Alves
2018-09-11 14:13 ` Rich Felker
2018-09-11 16:04 ` Pedro Alves
2018-09-11 18:22 ` Sergio Durigan Junior
2018-09-12 15:26 ` Pedro Alves
2018-09-12 17:11 ` Sergio Durigan Junior
2018-09-12 17:40 ` Pedro Alves
2018-09-11 10:13 ` Pedro Alves
2018-09-11 6:47 ` Thomas Petazzoni
2018-09-12 17:31 ` [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c Sergio Durigan Junior
2018-09-12 17:41 ` Pedro Alves [this message]
2018-09-12 17:59 ` Sergio Durigan Junior
2018-09-14 21:27 ` Romain Naour
2018-09-14 21:41 ` Tom Tromey
2018-09-14 21:48 ` Sergio Durigan Junior
2018-09-14 21:55 ` Romain Naour
2018-09-14 22:09 ` Joel Brobecker
2018-09-15 13:16 ` Romain Naour
2018-09-15 13:28 ` Romain Naour
2018-09-15 20:42 ` Sergio Durigan Junior
2018-09-17 17:01 ` Joel Brobecker
2018-09-15 20:35 ` Sergio Durigan Junior
2018-09-15 21:14 ` Romain Naour
2018-09-16 4:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com \
--to=palves@redhat.com \
--cc=dalias@aerifal.cx \
--cc=gdb-patches@sourceware.org \
--cc=romain.naour@gmail.com \
--cc=romain.naour@smile.fr \
--cc=sergiodj@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox