From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-150703-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 66306 invoked by alias); 12 Sep 2018 17:41:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 66287 invoked by uid 89); 12 Sep 2018 17:41:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:731
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Sep 2018 17:41:47 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id B2664DFDD;	Wed, 12 Sep 2018 17:41:45 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 8FE68A30CD;	Wed, 12 Sep 2018 17:41:42 +0000 (UTC)
Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c
To: Sergio Durigan Junior <sergiodj@redhat.com>, GDB Patches <gdb-patches@sourceware.org>
References: <d588888e-dccc-50c8-5a6e-9c5c46a512cb@smile.fr> <20180912173113.2007-1-sergiodj@redhat.com>
Cc: Rich Felker <dalias@aerifal.cx>, Romain Naour <romain.naour@smile.fr>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Romain Naour <romain.naour@gmail.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com>
Date: Wed, 12 Sep 2018 17:41:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180912173113.2007-1-sergiodj@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-09/txt/msg00368.txt.bz2

On 09/12/2018 06:31 PM, Sergio Durigan Junior wrote:

> The most simple fix for this problem is to move 'is_regular_file' to
> 'filestuff.c', which is not used by IPA.  This ends up making the
> files more logically organized as well, since 'is_regular_file' is a
> file operation.
> 
> No regressions found.
> 
> gdb/ChangeLog:
> 2018-09-12  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	* common/common-utils.c: Don't include '<sys/stat.h>'.
> 	(is_regular_file): Move to...
> 	* common/filestuff.c (is_regular_file): ... here.
> 	* common/common-utils.h (is_regular_file): Move to...
> 	* common/filestuff.h (is_regular_file): ... here.

OK.

Thanks,
Pedro Alves