Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c

[Romain Naour <romain.naour@smile.fr>]

Hi Sergio,

Le 15/09/2018 à 22:35, Sergio Durigan Junior a écrit :
> On Saturday, September 15 2018, Romain Naour wrote:
> 
>>>   - And the commit should have a corresponding GDB PR number
>>>     (https://sourceware.org/bugzilla/); the PR number acts as
>>>     a reference for "what's changed" in each corrective release,
>>>     so the clearer the explanation in the description, the better.
>>>
>>>     If you are the one motivated for the backport, it would be
>>>     helpful if you could take care of creating the PR. Sergio
>>>     offered to then backport it for you, but I can also help
>>>     with that.
>>
>> I'm agree on the principle but the change from gdb 8.2 introducing the issue has
>> been backported to gdb 8.1.x [1] without such GDB PR number (as far I can see).
>> IIUC, all patches backported to a stable branch must have a GDB PR number.
>> This is not always the case.
> 
> It is always the case.  Joel kindly reminded me (back then) that I had
> forgotten to create a PR for this backport:
> 
>   https://sourceware.org/ml/gdb-patches/2018-03/msg00001.html
> 
> And I did it subsequently:
> 
>   https://sourceware.org/bugzilla/show_bug.cgi?id=22907
> 
> Unfortunately, it was not possible to reference the PR number in the
> commit log anymore, but it was included in the official release note:
> 
>   https://sourceware.org/ml/gdb-announce/2018/msg00002.html

Sorry, I missed the reference to the PR.
Thanks for the links.

Best regards,
Romain

> 
> Thanks,
>