From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125440 invoked by alias); 15 Sep 2018 21:14:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125426 invoked by uid 89); 15 Sep 2018 21:14:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*Ad:D*fr, H*M:smile, kindly, HContent-Transfer-Encoding:8bit X-HELO: idris.smile.fr Received: from idris.smile.fr (HELO idris.smile.fr) (91.216.209.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Sep 2018 21:14:47 +0000 Received: from localhost (localhost [127.0.0.1]) by idris.smile.fr (Postfix) with ESMTP id BF6971EE265E; Sat, 15 Sep 2018 23:14:45 +0200 (CEST) Received: from idris.smile.fr ([127.0.0.1]) by localhost (bluemind-mta.prod.vitry.intranet [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NzIRMMZKHbCN; Sat, 15 Sep 2018 23:14:45 +0200 (CEST) Received: from [192.168.1.17] (LFbn-1-477-200.w86-245.abo.wanadoo.fr [86.245.183.200]) by idris.smile.fr (Postfix) with ESMTPSA id 90AFC1EE265C; Sat, 15 Sep 2018 23:14:45 +0200 (CEST) Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c To: Sergio Durigan Junior , Romain Naour Cc: Joel Brobecker , Tom Tromey , Pedro Alves , GDB Patches , Rich Felker , Thomas Petazzoni References: <20180912173113.2007-1-sergiodj@redhat.com> <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com> <874leulhqt.fsf@redhat.com> <203b1739-3418-2aa4-c40e-c2e63e717297@smile.fr> <87h8ir3gg6.fsf@tromey.com> <87in37oimf.fsf@redhat.com> <6e01d5ff-42bb-e1fc-162c-aa3fe97cf6b2@smile.fr> <20180914220940.GB26509@adacore.com> <1b59da32-0fa0-fd8f-ddd6-507e45df2988@smile.fr> <87k1nmcxdu.fsf@redhat.com> From: Romain Naour Message-ID: <6af7fa6c-7937-c4ea-1338-d8ed2d23e584@smile.fr> Date: Sat, 15 Sep 2018 21:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87k1nmcxdu.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-09/txt/msg00503.txt.bz2 Hi Sergio, Le 15/09/2018 à 22:35, Sergio Durigan Junior a écrit : > On Saturday, September 15 2018, Romain Naour wrote: > >>> - And the commit should have a corresponding GDB PR number >>> (https://sourceware.org/bugzilla/); the PR number acts as >>> a reference for "what's changed" in each corrective release, >>> so the clearer the explanation in the description, the better. >>> >>> If you are the one motivated for the backport, it would be >>> helpful if you could take care of creating the PR. Sergio >>> offered to then backport it for you, but I can also help >>> with that. >> >> I'm agree on the principle but the change from gdb 8.2 introducing the issue has >> been backported to gdb 8.1.x [1] without such GDB PR number (as far I can see). >> IIUC, all patches backported to a stable branch must have a GDB PR number. >> This is not always the case. > > It is always the case. Joel kindly reminded me (back then) that I had > forgotten to create a PR for this backport: > > https://sourceware.org/ml/gdb-patches/2018-03/msg00001.html > > And I did it subsequently: > > https://sourceware.org/bugzilla/show_bug.cgi?id=22907 > > Unfortunately, it was not possible to reference the PR number in the > commit log anymore, but it was included in the official release note: > > https://sourceware.org/ml/gdb-announce/2018/msg00002.html Sorry, I missed the reference to the PR. Thanks for the links. Best regards, Romain > > Thanks, >