From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Romain Naour <romain.naour@smile.fr>
Cc: Joel Brobecker <brobecker@adacore.com>,
Tom Tromey <tom@tromey.com>, Pedro Alves <palves@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>,
Rich Felker <dalias@aerifal.cx>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c
Date: Sun, 16 Sep 2018 04:59:00 -0000 [thread overview]
Message-ID: <87bm8yca1y.fsf@redhat.com> (raw)
In-Reply-To: <6af7fa6c-7937-c4ea-1338-d8ed2d23e584@smile.fr> (Romain Naour's message of "Sat, 15 Sep 2018 23:14:45 +0200")
On Saturday, September 15 2018, Romain Naour wrote:
> Hi Sergio,
>
> Le 15/09/2018 à 22:35, Sergio Durigan Junior a écrit :
>> On Saturday, September 15 2018, Romain Naour wrote:
>>
>>>> - And the commit should have a corresponding GDB PR number
>>>> (https://sourceware.org/bugzilla/); the PR number acts as
>>>> a reference for "what's changed" in each corrective release,
>>>> so the clearer the explanation in the description, the better.
>>>>
>>>> If you are the one motivated for the backport, it would be
>>>> helpful if you could take care of creating the PR. Sergio
>>>> offered to then backport it for you, but I can also help
>>>> with that.
>>>
>>> I'm agree on the principle but the change from gdb 8.2 introducing the issue has
>>> been backported to gdb 8.1.x [1] without such GDB PR number (as far I can see).
>>> IIUC, all patches backported to a stable branch must have a GDB PR number.
>>> This is not always the case.
>>
>> It is always the case. Joel kindly reminded me (back then) that I had
>> forgotten to create a PR for this backport:
>>
>> https://sourceware.org/ml/gdb-patches/2018-03/msg00001.html
>>
>> And I did it subsequently:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=22907
>>
>> Unfortunately, it was not possible to reference the PR number in the
>> commit log anymore, but it was included in the official release note:
>>
>> https://sourceware.org/ml/gdb-announce/2018/msg00002.html
>
> Sorry, I missed the reference to the PR.
> Thanks for the links.
No problem at all, it certainly wasn't obvious. Thanks for reporting
the bug and filing the PR :-).
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2018-09-16 4:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180909163750.14196-1-romain.naour@gmail.com>
[not found] ` <20180909163750.14196-2-romain.naour@gmail.com>
[not found] ` <20180910174900.0b9f4133@windsurf>
2018-09-10 21:21 ` [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system Romain Naour
2018-09-10 22:41 ` Rich Felker
2018-09-11 0:38 ` Sergio Durigan Junior
2018-09-11 9:51 ` Pedro Alves
2018-09-11 14:13 ` Rich Felker
2018-09-11 16:04 ` Pedro Alves
2018-09-11 18:22 ` Sergio Durigan Junior
2018-09-12 15:26 ` Pedro Alves
2018-09-12 17:11 ` Sergio Durigan Junior
2018-09-12 17:40 ` Pedro Alves
2018-09-11 10:13 ` Pedro Alves
2018-09-11 6:47 ` Thomas Petazzoni
2018-09-12 17:31 ` [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c Sergio Durigan Junior
2018-09-12 17:41 ` Pedro Alves
2018-09-12 17:59 ` Sergio Durigan Junior
2018-09-14 21:27 ` Romain Naour
2018-09-14 21:41 ` Tom Tromey
2018-09-14 21:48 ` Sergio Durigan Junior
2018-09-14 21:55 ` Romain Naour
2018-09-14 22:09 ` Joel Brobecker
2018-09-15 13:16 ` Romain Naour
2018-09-15 13:28 ` Romain Naour
2018-09-15 20:42 ` Sergio Durigan Junior
2018-09-17 17:01 ` Joel Brobecker
2018-09-15 20:35 ` Sergio Durigan Junior
2018-09-15 21:14 ` Romain Naour
2018-09-16 4:59 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm8yca1y.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=brobecker@adacore.com \
--cc=dalias@aerifal.cx \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox