From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58060 invoked by alias); 14 Sep 2018 22:09:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58051 invoked by uid 89); 14 Sep 2018 22:09:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=obscure, Hx-languages-length:1171, nervous X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Sep 2018 22:09:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0A7205602A; Fri, 14 Sep 2018 18:09:43 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ekM08JQgnmNx; Fri, 14 Sep 2018 18:09:42 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A897856029; Fri, 14 Sep 2018 18:09:42 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D8DB582E7C; Fri, 14 Sep 2018 15:09:40 -0700 (PDT) Date: Fri, 14 Sep 2018 22:09:00 -0000 From: Joel Brobecker To: Romain Naour Cc: Sergio Durigan Junior , Tom Tromey , Pedro Alves , GDB Patches , Rich Felker , Thomas Petazzoni , Romain Naour Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c Message-ID: <20180914220940.GB26509@adacore.com> References: <20180912173113.2007-1-sergiodj@redhat.com> <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com> <874leulhqt.fsf@redhat.com> <203b1739-3418-2aa4-c40e-c2e63e717297@smile.fr> <87h8ir3gg6.fsf@tromey.com> <87in37oimf.fsf@redhat.com> <6e01d5ff-42bb-e1fc-162c-aa3fe97cf6b2@smile.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e01d5ff-42bb-e1fc-162c-aa3fe97cf6b2@smile.fr> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-09/txt/msg00470.txt.bz2 Hello Romain, > > Me too. I can backport it to 8.2 if wanted. > > Yes please for the upcoming 8.2.1. Once a release has been made off a give branch, there are a couple of additional conditions before we can backport that change to that branch: - The patch needs to be safe, and you need approval from a Global Maintainer to do so; I looked at the patch, and although I was nervous about the removal of the #include at first, I checked the contents of the file, and I am reasonably certain that there isn't any other code that might needed on some obscure system. So you have my OK for the patch to be backported to the gdb-8.2-branch. - And the commit should have a corresponding GDB PR number (https://sourceware.org/bugzilla/); the PR number acts as a reference for "what's changed" in each corrective release, so the clearer the explanation in the description, the better. If you are the one motivated for the backport, it would be helpful if you could take care of creating the PR. Sergio offered to then backport it for you, but I can also help with that. Thank you, -- Joel