From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68833 invoked by alias); 11 Sep 2018 16:04:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68819 invoked by uid 89); 11 Sep 2018 16:04:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:694, collecting X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 16:04:52 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3965F87A87; Tue, 11 Sep 2018 16:04:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0DAA4D93DE; Tue, 11 Sep 2018 16:04:46 +0000 (UTC) Subject: Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system To: Rich Felker References: <20180909163750.14196-1-romain.naour@gmail.com> <20180909163750.14196-2-romain.naour@gmail.com> <20180910174900.0b9f4133@windsurf> <20180910224128.GT1878@brightrain.aerifal.cx> <87lg88oolv.fsf@redhat.com> <13772de6-1197-4182-e13f-3b4f27dfa22d@redhat.com> <20180911141312.GU1878@brightrain.aerifal.cx> Cc: Sergio Durigan Junior , Romain Naour , Thomas Petazzoni , Romain Naour , buildroot@buildroot.org, gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 11 Sep 2018 16:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180911141312.GU1878@brightrain.aerifal.cx> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00341.txt.bz2 On 09/11/2018 03:13 PM, Rich Felker wrote: > As an aside, the whole idea of running in-process code > referencing/using functions in the process being debugged (like stat > in libc) seems fragile and broken; perhaps aside from this > inadvertently-added use in is_regular_file, there is no such code in > the IPA stuff? There is (or there should be) no such code in the fast path, which is actually collecting tracepoints -- there are no syscalls in that path. If there were, the whole point of the IPA would be thrown out the window. There's some in setup code, but it hasn't been problematic. Thanks, Pedro Alves