Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Christian Biesinger <cbiesinger@google.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Update gnulib to current trunk
Date: Thu, 2 Jul 2020 19:49:53 +0100	[thread overview]
Message-ID: <e3c60660-0cb0-dd4d-b710-89404790a8a1@palves.net> (raw)
In-Reply-To: <CAPTJ0XFrYNUipYpejfC3zbBUgYUQqary3Y4XyTJoEijVMZv-vw@mail.gmail.com>

On 6/30/20 8:19 PM, Christian Biesinger via Gdb-patches wrote:
> It looks like the original message is in the moderation queue because
> it's a little too big, so re-sending this as a gzipped attachment.
> 
> This fixes two issues on Windows: Update.
> https://sourceware.org/pipermail/gdb-patches/2020-June/169978.html

This seems to be bringing in a good amount of churn.

I'm lazy, so I'll copy&paste my comments from:
 https://sourceware.org/legacy-ml/gdb-patches/2018-08/msg00768.html

"It is standard practice when updating gnulib to discuss the set of
modules that the exercise brings in due to module dependencies.
If we're now including some more modules, that may mean that
we could eliminate some older host compatibility code from gdb
in favor of gnulib's and list the module dependencies
explicitly in IMPORTED_GNULIB_MODULES in update-gnulib.h.

Conversely, there's a chance that we were depending on some
module that wasn't explicitly listed in IMPORTED_GNULIB_MODULES,
and an update could remove the module by mistake.

Another reason for that is that that are some modules that
are problematic for us (e.g., the one that pulls in Windows's
select replacement), so we need to look out for that, in case
it is pulled in by a dependency."



  reply	other threads:[~2020-07-02 18:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200630184349.4009048-1-cbiesinger@google.com>
2020-06-30 19:19 ` Christian Biesinger
2020-07-02 18:49   ` Pedro Alves [this message]
2020-07-02 19:02     ` Eli Zaretskii
2020-07-02 19:06       ` Pedro Alves
2020-07-06 18:19         ` Christian Biesinger
2020-07-15  2:40           ` Christian Biesinger
2020-07-16 14:56           ` Pedro Alves
2020-08-13 12:24             ` Tom de Vries
2020-08-23 21:37             ` Joel Brobecker
2020-08-23 21:41               ` Joel Brobecker
2020-08-24 13:46               ` Pedro Alves
2020-08-26 22:39                 ` Joel Brobecker
2020-08-27 19:41                   ` Christian Biesinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3c60660-0cb0-dd4d-b710-89404790a8a1@palves.net \
    --to=pedro@palves.net \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox