Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@palves.net>
Cc: Christian Biesinger <cbiesinger@google.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Update gnulib to current trunk
Date: Wed, 26 Aug 2020 15:39:11 -0700	[thread overview]
Message-ID: <20200826223911.GO24789@adacore.com> (raw)
In-Reply-To: <79e08407-9a87-f057-edb2-ca9621ae2b3a@palves.net>

> > I'm going to quote the whole discussion below hoping this helps make it
> > easier for you to remember the details of this thread. which is about
> > updating gnulib to a newer version in order to bring in a change that
> > Eli wants for support of mingw.org's version of MinGW. If we wanted
> > a quick summary, my understanding is that following: After a closer
> > inspection of the delta in terms of modules this update causes,
> > we found that:
> > 
> >   - btowc gets added, for which you say that we should keep an eye
> >     on it wrt the logic in gdb/gdb_wchar.h, but I understand
> >     we should be OK for now;
> > 
> >   - We lose gettimeofday, and decided to add it.
> > 
> >   - We lose sys_time, and you suggested that the easiest is probably
> >     to accept that for now.
> > 
> > I have taken Christian's patch, and rebased it (there was one conflict
> > in gnulib/configure, which I resolved by regenerating it), and then
> > modified it to add gettimeofday.
> > 
> > As it happens, when doing that, we get sys_time back, as well as
> > localtime-buffer too. So, even though we said we could wait and
> > do nothing about it, the question becomes moot.
[...]
> > Does this look OK to you now?
> 
> I'm not very interested in looking at the full diff -- I trust that
> it's OK.  The overall set of modules that is added / removed was
> my main interest, and what you say above sounds good.
> 
> Patch is OK with me.

Thank you Pedro. I did one more round of testing after rebasing,
and then just pushed to master.

-- 
Joel


  reply	other threads:[~2020-08-26 22:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200630184349.4009048-1-cbiesinger@google.com>
2020-06-30 19:19 ` Christian Biesinger
2020-07-02 18:49   ` Pedro Alves
2020-07-02 19:02     ` Eli Zaretskii
2020-07-02 19:06       ` Pedro Alves
2020-07-06 18:19         ` Christian Biesinger
2020-07-15  2:40           ` Christian Biesinger
2020-07-16 14:56           ` Pedro Alves
2020-08-13 12:24             ` Tom de Vries
2020-08-23 21:37             ` Joel Brobecker
2020-08-23 21:41               ` Joel Brobecker
2020-08-24 13:46               ` Pedro Alves
2020-08-26 22:39                 ` Joel Brobecker [this message]
2020-08-27 19:41                   ` Christian Biesinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826223911.GO24789@adacore.com \
    --to=brobecker@adacore.com \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox