From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 8FFDA384C004 for ; Wed, 26 Aug 2020 22:39:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8FFDA384C004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E8D7611663D; Wed, 26 Aug 2020 18:39:13 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wwbo0owJ3CtM; Wed, 26 Aug 2020 18:39:13 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 94D1B1165BE; Wed, 26 Aug 2020 18:39:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D88658341B; Wed, 26 Aug 2020 15:39:11 -0700 (PDT) Date: Wed, 26 Aug 2020 15:39:11 -0700 From: Joel Brobecker To: Pedro Alves Cc: Christian Biesinger , gdb-patches Subject: Re: [PATCH] Update gnulib to current trunk Message-ID: <20200826223911.GO24789@adacore.com> References: <20200630184349.4009048-1-cbiesinger@google.com> <83h7upwxjl.fsf@gnu.org> <2d285f8f-57be-2d4f-ce7f-57afe65c6898@palves.net> <791b00ea-60f3-3e3f-8d67-dd017b46ad57@palves.net> <20200823213725.GA12645@adacore.com> <79e08407-9a87-f057-edb2-ca9621ae2b3a@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79e08407-9a87-f057-edb2-ca9621ae2b3a@palves.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 22:39:16 -0000 > > I'm going to quote the whole discussion below hoping this helps make it > > easier for you to remember the details of this thread. which is about > > updating gnulib to a newer version in order to bring in a change that > > Eli wants for support of mingw.org's version of MinGW. If we wanted > > a quick summary, my understanding is that following: After a closer > > inspection of the delta in terms of modules this update causes, > > we found that: > > > > - btowc gets added, for which you say that we should keep an eye > > on it wrt the logic in gdb/gdb_wchar.h, but I understand > > we should be OK for now; > > > > - We lose gettimeofday, and decided to add it. > > > > - We lose sys_time, and you suggested that the easiest is probably > > to accept that for now. > > > > I have taken Christian's patch, and rebased it (there was one conflict > > in gnulib/configure, which I resolved by regenerating it), and then > > modified it to add gettimeofday. > > > > As it happens, when doing that, we get sys_time back, as well as > > localtime-buffer too. So, even though we said we could wait and > > do nothing about it, the question becomes moot. [...] > > Does this look OK to you now? > > I'm not very interested in looking at the full diff -- I trust that > it's OK. The overall set of modules that is added / removed was > my main interest, and what you say above sounds good. > > Patch is OK with me. Thank you Pedro. I did one more round of testing after rebasing, and then just pushed to master. -- Joel