Re: [PATCH] Update gnulib to current trunk

[Christian Biesinger <cbiesinger@google.com>]

Ping

On Mon, Jul 6, 2020, 13:19 Christian Biesinger <cbiesinger@google.com>
wrote:

> Fair enough. This is the module diff:
>
> --- /tmp/old 2020-07-06 13:04:17.837482577 -0500
> +++ /tmp/new 2020-07-06 13:02:48.636984706 -0500
> @@ -1,9 +1,12 @@
> +Module list with included dependencies (indented):
>      absolute-header
>    alloca
>      alloca-opt
>      arpa_inet
>      assure
>      at-internal
> +    attribute
> +    btowc
>      builtin-expect
>      c99
>    canonicalize-lgpl
> @@ -13,12 +16,12 @@
>      close
>      closedir
>    count-one-bits
> +    ctype
>      d-ino
>      d-type
>    dirent
>    dirfd
>      dirname-lgpl
> -    dosname
>      double-slash-root
>      dup
>      dup2
> @@ -52,8 +55,8 @@
>      getdtablesize
>      getlogin_r
>      getprogname
> +    getrandom
>      gettext-h
> -    gettimeofday
>    glob
>      glob-h
>      hard-locale
> @@ -62,6 +65,7 @@
>      intprops
>    inttypes
>      inttypes-incomplete
> +    isblank
>      isnand-nolibm
>      isnanl-nolibm
>      largefile
> @@ -69,7 +73,6 @@
>    limits-h
>      localcharset
>      locale
> -    localtime-buffer
>      lock
>    lstat
>      malloc-posix
> @@ -78,11 +81,13 @@
>      mbrtowc
>      mbsinit
>      mbsrtowcs
> +    mbtowc
>    memchr
>    memmem
>      memmem-simple
>      mempcpy
>      memrchr
> +    minmax
>    mkdir
>    mkdtemp
>    mkostemp
> @@ -132,13 +137,14 @@
>      strerror-override
>    strerror_r-posix
>      string
> +    strnlen
>      strnlen1
>    strstr
>      strstr-simple
>    strtok_r
> +    sys_random
>      sys_socket
>    sys_stat
> -    sys_time
>      sys_types
>      sys_uio
>      tempname
> @@ -156,5 +162,7 @@
>      windows-once
>      windows-recmutex
>      windows-rwlock
> +    wmemchr
> +    wmempcpy
>      xalloc-oversized
>
> It seems what is getting removed is:
> -    dosname  (deprecated module and we don't use dosname.h)
> -    gettimeofday (it looks like we use this in remote-fileio.c)
> -    localtime-buffer (looks like basically an implementation detail)
> -    sys_time (looks like GDB specifically did *not* want this per
> comments in gdbsupport/gdb_sys_time.h)
>
> So:
> - For gettimeofday, the fixes in
>
> https://www.gnu.org/software/gnulib/manual/html_node/gettimeofday.html#gettimeofday
> don't look that important for gdb, but we could include the module.
> Let me know if you want me to.
>
> - For sys_time, we could perhaps replace the #undef in gdb_sys_time.h
> with an #error. Let me know.
>
> Christian
>
> On Thu, Jul 2, 2020 at 2:07 PM Pedro Alves <pedro@palves.net> wrote:
> >
> > On 7/2/20 8:02 PM, Eli Zaretskii wrote:
> > >> From: Pedro Alves <pedro@palves.net>
> > >> Date: Thu, 2 Jul 2020 19:49:53 +0100
> > >>
> > >>> This fixes two issues on Windows: Update.
> > >>> https://sourceware.org/pipermail/gdb-patches/2020-June/169978.html
> > >>
> > >> This seems to be bringing in a good amount of churn.
> > >
> > > Maybe we should just update the two modules which were changed due to
> > > my reports?  Would that be safer?
> > >
> >
> > I don't know.  I'd be happy with just seeing the list of the
> > dependencies being pulled in and dropped before making such
> > a decision.  It's just a precautionary measure, the update is
> > probably fine.
> >
> > Pedro Alves
>