From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by sourceware.org (Postfix) with ESMTPS id 3379E3858D34 for ; Wed, 15 Jul 2020 02:40:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3379E3858D34 Received: by mail-qt1-x841.google.com with SMTP id b25so599566qto.2 for ; Tue, 14 Jul 2020 19:40:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GnYbImkHHBqDLVFIFVFRAK2/BW44dC/7kGWgeeOCBHY=; b=MvurX2fkLWYdX7jBT8nn3X0SH5u+plZJrkDuXRFAEOsmnHsrn1k60v7798/ow513xL lFY2sAXHrKxMeHhPCBBmreiwurySJOstAPS+9L9gd0ABgqmGWZfBJXczr31cxaQqi1Td VJzQHhWUw4V7P5iaT4C/2SzI6XbwKmjJWgPTF2PaFnsSl25pdPphpEu2kS/7Q1HbGwPX Y03uvio0g0FH2iVkd2H4mK+3GSPqsBGyk6p5frmWvBNNw5tq+p8qmCa4pSvORhbXNWCP Xr8GxJo2hXd3OoezyN/PR5rhYrwsY3WnopvMMP3m/PyY7IxIKU4LhrjfMmtSI6cIKn7R +UsA== X-Gm-Message-State: AOAM531oRvZlrI2Ds8/hXM8BKFGepBCIR5OFYIAJzi6WGSjq8zX0cv+S 191Igjwik7mVW0D86yu72egVrCQSUiLoiz/KMY+4S6+m X-Google-Smtp-Source: ABdhPJyLPsvSfazcY0Xtitglea7hwcDRt1KXGkAH+A35t3jqm7nsTFifFS3c7qrgnrXPz8CiymOZ1lxw+nOXMWeDz/I= X-Received: by 2002:ac8:7a9a:: with SMTP id x26mr7815500qtr.161.1594780819374; Tue, 14 Jul 2020 19:40:19 -0700 (PDT) MIME-Version: 1.0 References: <20200630184349.4009048-1-cbiesinger@google.com> <83h7upwxjl.fsf@gnu.org> <2d285f8f-57be-2d4f-ce7f-57afe65c6898@palves.net> In-Reply-To: From: Christian Biesinger Date: Tue, 14 Jul 2020 21:40:04 -0500 Message-ID: Subject: Re: [PATCH] Update gnulib to current trunk To: Pedro Alves Cc: Eli Zaretskii , gdb-patches X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 02:40:21 -0000 Ping On Mon, Jul 6, 2020, 13:19 Christian Biesinger wrote: > Fair enough. This is the module diff: > > --- /tmp/old 2020-07-06 13:04:17.837482577 -0500 > +++ /tmp/new 2020-07-06 13:02:48.636984706 -0500 > @@ -1,9 +1,12 @@ > +Module list with included dependencies (indented): > absolute-header > alloca > alloca-opt > arpa_inet > assure > at-internal > + attribute > + btowc > builtin-expect > c99 > canonicalize-lgpl > @@ -13,12 +16,12 @@ > close > closedir > count-one-bits > + ctype > d-ino > d-type > dirent > dirfd > dirname-lgpl > - dosname > double-slash-root > dup > dup2 > @@ -52,8 +55,8 @@ > getdtablesize > getlogin_r > getprogname > + getrandom > gettext-h > - gettimeofday > glob > glob-h > hard-locale > @@ -62,6 +65,7 @@ > intprops > inttypes > inttypes-incomplete > + isblank > isnand-nolibm > isnanl-nolibm > largefile > @@ -69,7 +73,6 @@ > limits-h > localcharset > locale > - localtime-buffer > lock > lstat > malloc-posix > @@ -78,11 +81,13 @@ > mbrtowc > mbsinit > mbsrtowcs > + mbtowc > memchr > memmem > memmem-simple > mempcpy > memrchr > + minmax > mkdir > mkdtemp > mkostemp > @@ -132,13 +137,14 @@ > strerror-override > strerror_r-posix > string > + strnlen > strnlen1 > strstr > strstr-simple > strtok_r > + sys_random > sys_socket > sys_stat > - sys_time > sys_types > sys_uio > tempname > @@ -156,5 +162,7 @@ > windows-once > windows-recmutex > windows-rwlock > + wmemchr > + wmempcpy > xalloc-oversized > > It seems what is getting removed is: > - dosname (deprecated module and we don't use dosname.h) > - gettimeofday (it looks like we use this in remote-fileio.c) > - localtime-buffer (looks like basically an implementation detail) > - sys_time (looks like GDB specifically did *not* want this per > comments in gdbsupport/gdb_sys_time.h) > > So: > - For gettimeofday, the fixes in > > https://www.gnu.org/software/gnulib/manual/html_node/gettimeofday.html#gettimeofday > don't look that important for gdb, but we could include the module. > Let me know if you want me to. > > - For sys_time, we could perhaps replace the #undef in gdb_sys_time.h > with an #error. Let me know. > > Christian > > On Thu, Jul 2, 2020 at 2:07 PM Pedro Alves wrote: > > > > On 7/2/20 8:02 PM, Eli Zaretskii wrote: > > >> From: Pedro Alves > > >> Date: Thu, 2 Jul 2020 19:49:53 +0100 > > >> > > >>> This fixes two issues on Windows: Update. > > >>> https://sourceware.org/pipermail/gdb-patches/2020-June/169978.html > > >> > > >> This seems to be bringing in a good amount of churn. > > > > > > Maybe we should just update the two modules which were changed due to > > > my reports? Would that be safer? > > > > > > > I don't know. I'd be happy with just seeing the list of the > > dependencies being pulled in and dropped before making such > > a decision. It's just a precautionary measure, the update is > > probably fine. > > > > Pedro Alves >