Re: [PATCH] Update gnulib to current trunk

[Christian Biesinger <cbiesinger@google.com>]

On Wed, Aug 26, 2020 at 5:39 PM Joel Brobecker <brobecker@adacore.com> wrote:
>
> > > I'm going to quote the whole discussion below hoping this helps make it
> > > easier for you to remember the details of this thread. which is about
> > > updating gnulib to a newer version in order to bring in a change that
> > > Eli wants for support of mingw.org's version of MinGW. If we wanted
> > > a quick summary, my understanding is that following: After a closer
> > > inspection of the delta in terms of modules this update causes,
> > > we found that:
> > >
> > >   - btowc gets added, for which you say that we should keep an eye
> > >     on it wrt the logic in gdb/gdb_wchar.h, but I understand
> > >     we should be OK for now;
> > >
> > >   - We lose gettimeofday, and decided to add it.
> > >
> > >   - We lose sys_time, and you suggested that the easiest is probably
> > >     to accept that for now.
> > >
> > > I have taken Christian's patch, and rebased it (there was one conflict
> > > in gnulib/configure, which I resolved by regenerating it), and then
> > > modified it to add gettimeofday.
> > >
> > > As it happens, when doing that, we get sys_time back, as well as
> > > localtime-buffer too. So, even though we said we could wait and
> > > do nothing about it, the question becomes moot.
> [...]
> > > Does this look OK to you now?
> >
> > I'm not very interested in looking at the full diff -- I trust that
> > it's OK.  The overall set of modules that is added / removed was
> > my main interest, and what you say above sounds good.
> >
> > Patch is OK with me.
>
> Thank you Pedro. I did one more round of testing after rebasing,
> and then just pushed to master.

Thanks for taking care of this. Sorry I dropped the ball here! Work
and life has been keeping me busy.

Christian