From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id 5BE023860C37 for ; Thu, 27 Aug 2020 19:42:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5BE023860C37 Received: by mail-qk1-x742.google.com with SMTP id o12so7132548qki.13 for ; Thu, 27 Aug 2020 12:42:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5DhsAYqWvJKy1E5VlWDTRLkFrLlX7BPkRxC3rDDxUHM=; b=qUP9NxdAuvUAAsHRvYOaC2SdA0W1KNmsaQippEeATW0AK8k6gfEzcmlxz1hWCR/Py6 HqkArNSAtQU22oPWAO9B//Rc5biJ93FRazEn+DBoFgL+zgPWOjHBc1B/1rwiWNx9Hzia CNJREWHqDyZjK3ybkm+Q0TwGfr/zaLVKNMZoXxKpeivpdnpoWytuy9nZZ8ZWECyGCr0S M1AOZ/+d1dkRnViMG+EvSjlxpcLcgYrnkqTmz8zwGiqVfObShvhh/oDP9D9nMv9u6uOS ylyPL+ghb3bMbwzAz8pzqWXv8SvxkNQGRbOO4x+5nRY7XQ1RNpDI/29tUlPtaIkafw6h kdIQ== X-Gm-Message-State: AOAM5317gD17SMUXc+9HCfsr/cktxxlgTwBIK8VKS/CQ7rvrWga707WQ wOVLVvT4r2eE8ZPUgLbC+11J/MQK+5NXzj1k9fid8JaeyWU= X-Google-Smtp-Source: ABdhPJxOOtoksT7/HHhIS7bTBB0Ve7K+GJqCmAQf5QgI0M67uqVsAlLYQdlWmhfjB1NlSgTJ0j6l3ifzKBypdOgeEn4= X-Received: by 2002:a37:7207:: with SMTP id n7mr16615616qkc.375.1598557319605; Thu, 27 Aug 2020 12:41:59 -0700 (PDT) MIME-Version: 1.0 References: <20200630184349.4009048-1-cbiesinger@google.com> <83h7upwxjl.fsf@gnu.org> <2d285f8f-57be-2d4f-ce7f-57afe65c6898@palves.net> <791b00ea-60f3-3e3f-8d67-dd017b46ad57@palves.net> <20200823213725.GA12645@adacore.com> <79e08407-9a87-f057-edb2-ca9621ae2b3a@palves.net> <20200826223911.GO24789@adacore.com> In-Reply-To: <20200826223911.GO24789@adacore.com> From: Christian Biesinger Date: Thu, 27 Aug 2020 14:41:22 -0500 Message-ID: Subject: Re: [PATCH] Update gnulib to current trunk To: Joel Brobecker Cc: Pedro Alves , gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 19:42:01 -0000 On Wed, Aug 26, 2020 at 5:39 PM Joel Brobecker wrote: > > > > I'm going to quote the whole discussion below hoping this helps make it > > > easier for you to remember the details of this thread. which is about > > > updating gnulib to a newer version in order to bring in a change that > > > Eli wants for support of mingw.org's version of MinGW. If we wanted > > > a quick summary, my understanding is that following: After a closer > > > inspection of the delta in terms of modules this update causes, > > > we found that: > > > > > > - btowc gets added, for which you say that we should keep an eye > > > on it wrt the logic in gdb/gdb_wchar.h, but I understand > > > we should be OK for now; > > > > > > - We lose gettimeofday, and decided to add it. > > > > > > - We lose sys_time, and you suggested that the easiest is probably > > > to accept that for now. > > > > > > I have taken Christian's patch, and rebased it (there was one conflict > > > in gnulib/configure, which I resolved by regenerating it), and then > > > modified it to add gettimeofday. > > > > > > As it happens, when doing that, we get sys_time back, as well as > > > localtime-buffer too. So, even though we said we could wait and > > > do nothing about it, the question becomes moot. > [...] > > > Does this look OK to you now? > > > > I'm not very interested in looking at the full diff -- I trust that > > it's OK. The overall set of modules that is added / removed was > > my main interest, and what you say above sounds good. > > > > Patch is OK with me. > > Thank you Pedro. I did one more round of testing after rebasing, > and then just pushed to master. Thanks for taking care of this. Sorry I dropped the ball here! Work and life has been keeping me busy. Christian