From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by sourceware.org (Postfix) with ESMTPS id 2F6023858D34 for ; Thu, 2 Jul 2020 18:49:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2F6023858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f68.google.com with SMTP id b6so29667569wrs.11 for ; Thu, 02 Jul 2020 11:49:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ybh0i77lwUDa4OuJkC7LZTit5QcU/afkuFi1itf+NbI=; b=W1VFPzUnWdeLbmwZSfc5y5y25WGdFVukrl1WppMQ1XD7ivXCBlAFQ8YY9TMNItcdE+ 8xdFOnz40NQ+GlBnpQAGqzuxVOEhyQJsTo7BjVwGIOchjxeoRk1as+IHJgpxa07QUi47 8y0zbLg7gWTQNpDo9/47QMPOuhMqN8L2JQnfbyU5/wcVru4GSvMPVU2oTLJzXrETFggp +lGS7X2TBLvxXCqAHS24W/nnKkCTrZzeB2U1bYIsZ8jIPqxXhlfE8GO3+rNj/u+hv9s+ rQsEcAHv3KLXjLGFsHrcsTUV9yNW/X16GfQCScL0swp8zoYZ0O5nJ78wa226iJVZJYTc WPfw== X-Gm-Message-State: AOAM533xp1mwcTw0uIJ+u0Qms0nuxhmZmFyEMLfo6A4uACxKT2Fae5Er gIq914zrGJ0vhHngmj4/YWYnBPnhnY+g9Q== X-Google-Smtp-Source: ABdhPJy3EnkjnsqLVAegGO46efaiU1KYygCO4111MW2NvgcgqsIKSeuCpORRMvgCz+vBnHslfc3UTA== X-Received: by 2002:adf:f60a:: with SMTP id t10mr24373600wrp.64.1593715794942; Thu, 02 Jul 2020 11:49:54 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z132sm11407788wmb.21.2020.07.02.11.49.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 11:49:53 -0700 (PDT) Subject: Re: [PATCH] Update gnulib to current trunk To: Christian Biesinger , gdb-patches References: <20200630184349.4009048-1-cbiesinger@google.com> From: Pedro Alves Message-ID: Date: Thu, 2 Jul 2020 19:49:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2020 18:49:57 -0000 On 6/30/20 8:19 PM, Christian Biesinger via Gdb-patches wrote: > It looks like the original message is in the moderation queue because > it's a little too big, so re-sending this as a gzipped attachment. > > This fixes two issues on Windows: Update. > https://sourceware.org/pipermail/gdb-patches/2020-June/169978.html This seems to be bringing in a good amount of churn. I'm lazy, so I'll copy&paste my comments from: https://sourceware.org/legacy-ml/gdb-patches/2018-08/msg00768.html "It is standard practice when updating gnulib to discuss the set of modules that the exercise brings in due to module dependencies. If we're now including some more modules, that may mean that we could eliminate some older host compatibility code from gdb in favor of gnulib's and list the module dependencies explicitly in IMPORTED_GNULIB_MODULES in update-gnulib.h. Conversely, there's a chance that we were depending on some module that wasn't explicitly listed in IMPORTED_GNULIB_MODULES, and an update could remove the module by mistake. Another reason for that is that that are some modules that are problematic for us (e.g., the one that pulls in Windows's select replacement), so we need to look out for that, in case it is pulled in by a dependency."