Re: [PATCH 02/29] gdb/testsuite: Remove duplicates from gdb.base/miscexprs.exp

[Pedro Alves <pedro@palves.net>]

On 2021-12-14 23:28, Lancelot SIX wrote:
>>
>> Can you just drop the explicit names instead?
>>
>> That's the actual problem, the duplication, and
>> us humans failing at it.  Removing the duplication nips the problem in the bud, so it doesn't
>> ever happen again if someone adds more tests.
>>
>> So we'd just have:
>>
>>   gdb_test "print sbig.s\[90\] * 10" " = 2550"
>>
>> etc.
>>
>> We lose the "value of" part but that seems harmless.
> 
> Hi,
> 
> Indeed, the exp file is much cleaner after removing the smewhat useless
> explicit test names (but the patch itself is longer).
> 
> I have replaced this patch locally with the following.
> 
> Thanks for the feedback.
> 
> Best,
> Lancelot.
> 
> ---
> From 986d73aab7c604033b98ca8c0bbd472ae92ada66 Mon Sep 17 00:00:00 2001
> From: Lancelot SIX <lsix@lancelotsix.com>
> Date: Fri, 19 Nov 2021 19:05:37 +0000
> Subject: [PATCH] gdb/testsuite: Remove duplicates from gdb.base/miscexprs.exp
> 
> When running the testsuite I see:
> 
>     Running .../gdb/testsuite/gdb.base/miscexprs.exp ...
>     DUPLICATE: gdb.base/miscexprs.exp: print value of !ibig.i[100]
>     DUPLICATE: gdb.base/miscexprs.exp: print value of !ibig.i[100]
> 
> This is due to an explicit test name repeated across multiple tests.
> The actual test explicit names do not add much over the command from
> wich default test names are derived.
> 
> Fix by removing the explicit test names across the file where they do
> not add value.  While at doing some cleaning, also use $gdb_test_name in
> the various uses of gdb_test_multiple.
> 
> Tested on x86_64-linux.

OK.