Re: [PATCH 10/29] gdb/testsuite: Remove duplicates from gdb.base/del.exp

[Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>]

* Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> [2021-11-21 17:56:17 +0000]:

> When running the testsuite, I have:
> 
>     Running .../gdb/testsuite/gdb.base/del.exp ...
>     DUPLICATE: gdb.base/del.exp: info break after removing break on main
> 
> Refactor slightly this test to run the various configurations under
> foreach_with_prefix so each variant is automatically prefixed, ensuring
> that the forgotten custom test name cannot happen.
> 
> Tested on x86_64-linux.

LGTM.

Thanks,
Andrew

> ---
>  gdb/testsuite/gdb.base/del.exp | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.base/del.exp b/gdb/testsuite/gdb.base/del.exp
> index 7b1f24b8686..8dc12b7089b 100644
> --- a/gdb/testsuite/gdb.base/del.exp
> +++ b/gdb/testsuite/gdb.base/del.exp
> @@ -32,30 +32,30 @@ proc test_delete_alias { alias } {
>      # First of all, remove all previous breakpoints if there were any,
>      # and then verify that we do not have any breakpoint lying around.
>      gdb_test_no_output "delete" \
> -             "remove all breakpoints ($alias)"
> +             "remove all breakpoints"
>  
>      gdb_test "info break" \
>               "No breakpoints or watchpoints." \
> -             "info break after removing break on main"
> +             "info break after clearing breakpoints"
> +
>  
> -    
>      # Now, insert a breakpoint at an easy location, and then remove it
>      # using $alias. We verified that the removal worked by checking
>      # the list of breakpoints.
>      gdb_test "break -q main" \
>               "Breakpoint.*at.* file .*$srcfile, line.*" \
> -             "breakpoint insertion ($alias)"
> -    
> +             "breakpoint insertion"
> +
>      gdb_test_no_output "$alias \$bpnum" \
> -             "Remove last breakpoint ($alias)"
> -    
> +             "Remove last breakpoint"
> +
>      gdb_test "info break" \
>               "No breakpoints or watchpoints." \
> -             "info break after removing break on main ($alias)"
> +             "info break after removing break on main"
>  }
>  
>  # Test various shortcut forms of the "delete" command.
>  
> -test_delete_alias "del"
> -test_delete_alias "d"
> -
> +foreach_with_prefix alias {"del" "d"} {
> +    test_delete_alias $alias
> +}
> -- 
> 2.33.1
>