From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id V1pPL/xX1GG+JAAAWB0awg (envelope-from ) for ; Tue, 04 Jan 2022 09:21:48 -0500 Received: by simark.ca (Postfix, from userid 112) id ADF561F0DB; Tue, 4 Jan 2022 09:21:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2CE7A1ECEB for ; Tue, 4 Jan 2022 09:21:48 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5AB73858426 for ; Tue, 4 Jan 2022 14:21:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5AB73858426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641306107; bh=XrwUCNETpsRpIYHiMev2BDPbI7zY9hAHkkz2wPg/ozE=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GWw7ZmbeNJkAqhZTMF7hc7gxx0H+8uxTYXMIm1mXevuz4we1ZQEriM3+oP+HSHAlY YHgLExkGNCpGqTVS1mrLXIGjf4wSN92gpoFuRRh8Cyz2DeMlsK0oXg52vWbjG/9YrF adAIEDRaRfOMk3E+6K2MnXFQG2dOPtfvB7FYe3Gk= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 213C93858436 for ; Tue, 4 Jan 2022 14:21:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 213C93858436 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-27-mAn8E50nPWqe4qwXecU5zQ-1; Tue, 04 Jan 2022 09:20:58 -0500 X-MC-Unique: mAn8E50nPWqe4qwXecU5zQ-1 Received: by mail-wm1-f69.google.com with SMTP id x21-20020a05600c21d500b00345a25ea8cfso354613wmj.5 for ; Tue, 04 Jan 2022 06:20:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XrwUCNETpsRpIYHiMev2BDPbI7zY9hAHkkz2wPg/ozE=; b=TC6JZRnObEyM8yElkUpjy2uq7h2Cu9So7ewCmx5RSe7by8h9jPtWqvhFJzmzxmvPkB B9O5sHrCCHWaaoSJwWbwcqTtDLoltaSrdEdwGcrz/q/wBUoU8duqYAk1aSK2qCtEbmZ5 TvpKOcUW9e6ita76LNIWtTHvY89R+/tkKdlzvERi/8xdqsjNXn+EkOCRlAL1I/o6Qrm+ HxOqWJj8HT2NR+BexqcaXgwDj66PES264B4xeI5FfBxc/RRCHDqMHywsptNZCYpcNApC dxyUET/3YIivKcAmE3+u44XfeERWXLNDVqBMhygw3HD8WE0SWaS8QClUWJ+AksMg+Kz0 yeLA== X-Gm-Message-State: AOAM533rSOCHoJCD26rcmgjFxcmgD47eDiJVGai8AG/RKy87PZpME4sG BGRcwSk0KOx27WK3pIE1V+rgRdV++LHr9ZQwXXeJKbfZMxBixe4kdxkzf60QkbZ6MZ0geBqD3ru ONLIWC/i3c+L6typeOAF+MA== X-Received: by 2002:a5d:6349:: with SMTP id b9mr41402200wrw.152.1641306057132; Tue, 04 Jan 2022 06:20:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJxiTA88mU1AyqQ6TF0SQ4FTpUZ2mMI6zm/Ydkzd4GsuhnK0yPn7b8zMdnN+YdDtzOsmnRDo8w== X-Received: by 2002:a5d:6349:: with SMTP id b9mr41402185wrw.152.1641306056896; Tue, 04 Jan 2022 06:20:56 -0800 (PST) Received: from localhost (host109-154-163-67.range109-154.btcentralplus.com. [109.154.163.67]) by smtp.gmail.com with ESMTPSA id e1sm39217946wrc.74.2022.01.04.06.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 06:20:56 -0800 (PST) Date: Tue, 4 Jan 2022 14:20:55 +0000 To: Lancelot SIX Subject: Re: [PATCH 10/29] gdb/testsuite: Remove duplicates from gdb.base/del.exp Message-ID: <20220104142055.GK1845520@redhat.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-11-lsix@lancelotsix.com> MIME-Version: 1.0 In-Reply-To: <20211121175636.779325-11-lsix@lancelotsix.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 14:20:43 up 2 days, 23:14, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Lancelot SIX via Gdb-patches [2021-11-21 17:56:17 +0000]: > When running the testsuite, I have: > > Running .../gdb/testsuite/gdb.base/del.exp ... > DUPLICATE: gdb.base/del.exp: info break after removing break on main > > Refactor slightly this test to run the various configurations under > foreach_with_prefix so each variant is automatically prefixed, ensuring > that the forgotten custom test name cannot happen. > > Tested on x86_64-linux. LGTM. Thanks, Andrew > --- > gdb/testsuite/gdb.base/del.exp | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/del.exp b/gdb/testsuite/gdb.base/del.exp > index 7b1f24b8686..8dc12b7089b 100644 > --- a/gdb/testsuite/gdb.base/del.exp > +++ b/gdb/testsuite/gdb.base/del.exp > @@ -32,30 +32,30 @@ proc test_delete_alias { alias } { > # First of all, remove all previous breakpoints if there were any, > # and then verify that we do not have any breakpoint lying around. > gdb_test_no_output "delete" \ > - "remove all breakpoints ($alias)" > + "remove all breakpoints" > > gdb_test "info break" \ > "No breakpoints or watchpoints." \ > - "info break after removing break on main" > + "info break after clearing breakpoints" > + > > - > # Now, insert a breakpoint at an easy location, and then remove it > # using $alias. We verified that the removal worked by checking > # the list of breakpoints. > gdb_test "break -q main" \ > "Breakpoint.*at.* file .*$srcfile, line.*" \ > - "breakpoint insertion ($alias)" > - > + "breakpoint insertion" > + > gdb_test_no_output "$alias \$bpnum" \ > - "Remove last breakpoint ($alias)" > - > + "Remove last breakpoint" > + > gdb_test "info break" \ > "No breakpoints or watchpoints." \ > - "info break after removing break on main ($alias)" > + "info break after removing break on main" > } > > # Test various shortcut forms of the "delete" command. > > -test_delete_alias "del" > -test_delete_alias "d" > - > +foreach_with_prefix alias {"del" "d"} { > + test_delete_alias $alias > +} > -- > 2.33.1 >