Re: [PATCH 02/29] gdb/testsuite: Remove duplicates from gdb.base/miscexprs.exp

[Pedro Alves <pedro@palves.net>]

On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote:
> When running the testsuite I see:
> 
>     Running .../gdb/testsuite/gdb.base/miscexprs.exp ...
>     DUPLICATE: gdb.base/miscexprs.exp: print value of !ibig.i[100]
>     DUPLICATE: gdb.base/miscexprs.exp: print value of !ibig.i[100]
> 
> Fix the name of some misnamed tests.
> 
> Tested on x86_64.
> ---
>  gdb/testsuite/gdb.base/miscexprs.exp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.base/miscexprs.exp b/gdb/testsuite/gdb.base/miscexprs.exp
> index 86f41215283..c1fc7420545 100644
> --- a/gdb/testsuite/gdb.base/miscexprs.exp
> +++ b/gdb/testsuite/gdb.base/miscexprs.exp
> @@ -118,10 +118,10 @@ gdb_test "print !sbig.s\[90\]" " = $false" \
>      "print value of !sbig.s\[90\]"
>  
>  gdb_test "print !fbig.f\[100\]" " = $false" \
> -    "print value of !ibig.i\[100\]"
> +    "print value of !fbig.f\[100\]"
>  
>  gdb_test "print !dbig.d\[202\]" " = $false" \
> -    "print value of !ibig.i\[100\]"
> +    "print value of !dbig.d\[202\]"
>  
>  gdb_test "print sbig.s\[90\] * 10" " = 2550" \
>      "print value of !sbig.s\[90\] * 10"
> 

Can you just drop the explicit names instead?

That's the actual problem, the duplication, and
us humans failing at it.  Removing the duplication nips the problem in the bud, so it doesn't
ever happen again if someone adds more tests.

So we'd just have:

  gdb_test "print sbig.s\[90\] * 10" " = 2550"

etc.

We lose the "value of" part but that seems harmless.