Re: [PATCH 29/29] gdb/testsuite: Remove duplicates from gdb.base/corefile-buildid.exp

[Pedro Alves <pedro@palves.net>]

On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote:
> When running the testsuite, I have:
> 
>     Running .../gdb/testsuite/gdb.base/corefile-buildid.exp ...
>     WARNING: can't generate a core file - core tests suppressed - check ulimit -c
>     WARNING: can't generate a core file - core tests suppressed - check ulimit -c
>     DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file
>     WARNING: can't generate a core file - core tests suppressed - check ulimit -c
>     DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file
>     WARNING: can't generate a core file - core tests suppressed - check ulimit -c
>     DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file
> 
> The WARNING itself is related to my test environment, not the test
> istelf so I do not try to address it here.
> 
> Fix the DUPLICATEs by ensuring the test name is generated consistently
> with the rest of the file (i.e. by using $prefix in the name).
> 
> Tested on x86_64-linux.
> ---
>  gdb/testsuite/gdb.base/corefile-buildid.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.base/corefile-buildid.exp b/gdb/testsuite/gdb.base/corefile-buildid.exp
> index 15509be7039..bb1d4051b07 100644
> --- a/gdb/testsuite/gdb.base/corefile-buildid.exp
> +++ b/gdb/testsuite/gdb.base/corefile-buildid.exp
> @@ -260,7 +260,7 @@ proc do_corefile_buildid_tests {args} {
>      # Find the core file.
>      set corefile [core_find $program_to_run]
>      if {$corefile == ""} {
> -	untested "could not generate core file"
> +	untested "$suffix: could not generate core file"

There's another untested call below that would need the same treatment.  I was going to suggest
with_test_prefix, but realized the code is already using that.  Turns out Simon already
did that change meanwhile:

 https://sourceware.org/pipermail/gdb-patches/2021-December/183982.html

So you can drop this patch.

>  	return
>      }
>      verbose -log "corefile is $corefile"
>